What surprised me is that they want you to collate all the review comments in an excel sheet. Being asked to put code comments in an excel sheet is one of my pet peeves. It's never effective in my experience. If people know they'll have to write it up in excel, then they tend to be conservative in the review itself - you'll mostly see four or five vague comments like "refactor ". Marked-up printouts (as the authors themselves suggest) are the best means of doing code reviews. Just make sure you preserve the printouts for follow-up reviews (and in case your company's "process" or "quality" dept starts hounding you).
Slashdot Mirror
What surprised me is that they want you to collate all the review comments in an excel sheet. Being asked to put code comments in an excel sheet is one of my pet peeves. It's never effective in my experience. If people know they'll have to write it up in excel, then they tend to be conservative in the review itself - you'll mostly see four or five vague comments like "refactor ". Marked-up printouts (as the authors themselves suggest) are the best means of doing code reviews. Just make sure you preserve the printouts for follow-up reviews (and in case your company's "process" or "quality" dept starts hounding you).