Slashdot Mirror


IP Theft in the Linux Kernel

Søren Schmidt was browsing through the 2.4.10 linux kernel source when he saw something that looked a bit familiar. Too familiar in fact. Søren is the principle developer of FreeBSD's ATA drivers, including FreeBSD's support for ATA RAID cards, and as he looked through the linux/drivers/ide/ files the sense of deja vu was overwhelming. Read on for more.

"They just took my code and filed off the copyright" said Søren. "This is clearest with the two header files hptraid.h and pdcraid.h. Compare these with FreeBSD's ata-raid.h, and just look at the similarities." And it's true that these two header files certainly look like a chopped up copy of the FreeBSD header, after a quick search-and-replace. "The reading of the RAID config from the disks is their own code, but is clearly "inspired" from our code," said Søren, "but that's encouraged by the license. It's the verbatim use of the other code without retaining the copyright that's the problem."

ata-raid.h, and the other files, are copyright Søren, and released under the three clause BSD license, which includes the restriction "Redistributions of source code must retain the above copyright notice". So using these files, or significant portions of them, in your own code, without retaining the copyright information, as has happened here, is prohibited.

You may be thinking "This is only a couple of header files, what's the big deal?". As Søren says "The problem here is that the structures in the headers is the whole story. That info tells how you read the proprietary struct off the disks, and was reverse engineered and documented by me after a lot of effort." Søren's intellectual property is tied up in those files.

Right now, Søren is in discussions with the authors of the Linux ATA drivers (employed by RedHat) to ensure that his copyright notice is returned to these and other files, and to ensure that this situation does not recur. And it is hoped that an amicable solution can be reached.

10 of 1,000 comments (clear)

  1. Re:And yet... by geomcbay · · Score: 5, Informative

    Microsoft has incorporated BSD code into Windows various times, each time giving proper credit and keeping copyright notices intact.

    Don't try to reflect this onto Microsoft. Clearly the Linux developers fucked up here.

  2. Sets a good example by jekk · · Score: 5, Insightful
    Please folks, remember this the next time /. posts some s t o r y about a violation of the GPL liscense. Give them a chance, after it's been pointed out, to resolve things peacefully.

    Of course, I wouldn't propose that we allow violations of open source liscenses to continue unchecked, just that the opportunity for good faith resolutions be allowed before crying "Boycott!".

  3. Another argument for free software? by melquiades · · Score: 5, Insightful

    Developers give all kinds of reasons for developing free software -- noble spirit, peer respect, etc. -- but one of the big ones is all the shit you don't have to deal with.

    Case in point: there is every reason to think that this author's name will be included with his code in the next release of the Linux kernel source. Think how vastly different this situation would be if this were about theft of proprietary code. Here, nobody's company is at stake, and nobody stands to lose by doing the right thing -- so there are no stupid lawsuits and no hard feelings. At least, I hope it plays out this way ... but the odds are with it.

    Forget all this paranoia about the venemous GPL. Proprietary code has a really, really high cost of ownership; at a certain point, it's just not worth it. Free is just so ... easy. Yay!

  4. Red Hat source - who is "Arjanv" ? by Gothmolly · · Score: 5, Informative

    Here is the location at RedHat where you can get the code and patch. Link found on The Linux IDE Project Site

    --
    I want to delete my account but Slashdot doesn't allow it.
    1. Re:Red Hat source - who is "Arjanv" ? by ComputerSlicer23 · · Score: 5, Informative
      His full name is listed in the comments:

      Arjan van de Ven

      Notice also that it appears that the code has been updated to include the proper copyright and notices on the site. Read the diff, and the source all of the stuff has been added. It appears that it should be in compliance with the BSD license now.
  5. Re:Er... by JWhitlock · · Score: 5, Insightful
    Can someone explain to me *why* a developer would strip off copyright info? It's not like there are licensing fees; the guy just wants his code to be recognized and attributed. It doesn't make much sense to me...could it have been an honest mistake or a coincidence? (I'm not a programmer, so I haven't looked at the two files in question, which would mean nothing to me anyway.)

    I think it was more of a matter of lazy programming than evil intentions. The header files define structures, a few constants, etc. They encode a bit of knowledge, such as data formats and the meaning of that data, but some people wouldn't consider it code. More of an interface description. Of course, if it was a document describing an interface, then most people would automatically consider the copyright to hold...

    It's a bit like other forms of online "theft". Some folks think that if you download the html for a popular site, remove all the text and images, and use the layout on their own site, then it's not theft, because the copyrightable parts (images, text) were removed, and only the framework retained. But, like HTML framework, headers are the work of the programmer, and any desired copyright should be respected.

    Again, I'm in the "simple mistake, fix it, move on" camp, and would like to add that Red Hat and the rest should add a line to their policy about reusing "open source" code, to retain copyrights.

    If Microsoft did it, I'd expect them to do the same, but Microsoft would probably do it to force the issue, make the EFF take them to trial to define the limits of open source, the BSD liscence , and the GPL liscense. That's the difference - this will be taken care of by peers, while Microsoft conflicts almost always involve lawyers. It's the difference between getting rear-ended by an honest citizen (with or without the insurance companies getting involved), vs. an asshole celebrity who thinks the little people should take their licks and not annoy the "important people" with trivial matters like car bills and possible medical expenses.

  6. Reverse engineering, plagiarism, and theft by Old+Man+Kensey · · Score: 5, Informative
    none2222 wrote:

    Okay, so Søren reverse engineers the proprietary data structures developed at great cost by corporations, and then bitches when his work is ripped off by one of his fellow Open Source travelers. Give me a break!

    First, what Soren did was not plagiarism (claiming another's work as his own) nor theft (stealing another's property). He just made a part that works as a replacement for a factory part, much like the thriving parts industry in the auto world.

    What Red Hat's developers did wasn't "theft", since they were not required to have permission to use or modify and re-release the code. It was plagiarism -- essentially they took some of Soren's parts (which were free for the taking), filed off the serial numbers, then stamped their own on.

    It's not illegal to sell someone else's parts if you acquired them legally, but it is illegal to claim them as your own make without permission, regardless of how they were acquired.

    The only place Soren might have problems is if the driver algorithms were patented, and even there drivers exist in a world of murky law apart from applications. I seem to remember some abortive efforts by sound and video card manufacturers to squash third-party open-source drivers that got such negative press reaction that they were abandoned.

    --
    -- Old Man Kensey
  7. How it started... by Anonymous Coward · · Score: 5, Informative

    http://uwsg.iu.edu/hypermail/linux/kernel/0012.3/0 538.html

    > I've read everything that I can find regarding support of the Highpoint
    > controllers RAID functionality under Linux, and I understand what the issues
    > have been. The one promising bit of information that I dug up in this process is
    > that the 'pseudo' RAID functionality of the Highpoint and Promise IDE RAID
    > controllers is now supported in FreeBSD (4.2-RELEASE and 5.0-CURRENT). My
    > question is, can the new BSD code be leveraged to add support for these
    > controllers to the Linux kernel, and could we reasonably expect to see such
    > support in the near future?
    >
    > (I think that most all of the relevant/important bits are in ata-raid.c and/or
    > ata-raid.h. In
    > any event, the IDE/ATA guy over on the FreeBSD side is Soren Schmidt
    > (sos@freebsd.org), and he
    > wrote all of the stuff for this.

  8. Re:And yet... by lupercalia · · Score: 5, Insightful

    This is clearly the fault of just one PROGRAMMER.

    Does your boss see all the code you write, and if s/he did would s/he recognize BSD ATA code? Mine sure wouldn't.

  9. Re:And yet... by Jabes · · Score: 5, Insightful
    I wonder where Microsoft (or anyone else distributing binary BSD-licensed software) does this. At least I didn't find it in Windows 2000's documentation (both online and offline). I have only the OEM version so my only manual is a quick start guide, but still the notice should be somewhere if Microsoft doesn't break the license.

    I don't know about Windows 2000, but I've got RTM Windows XP here. On the CD in the root directory is a README file. Here's some of it...

    Acknowledgements Portions of this product are based in part on the work of Mark H. Colburn and sponsored by the USENIX Association. Copyright © 1989 Mark H. Colburn. All rights reserved.

    This product includes software developed by the University of California, Berkeley and its contributors.

    Portions of this product are based in part on the work of the Regents of the University of California, Berkeley and its contributors. Because Microsoft has included the Regents of the University of California, Berkeley, software in this product, Microsoft is required to include the following text that accompanied such software:

    Copyright © 1985, 1988 Regents of the University of California. All rights reserved.

    Redistribution and use in source and binary forms are permitted provided that the above copyright notice and this paragraph are duplicated in all such forms and that any documentation, advertising materials, and other materials related to such distribution and use acknowledge that the software was developed by the University of California, Berkeley. The name of the University may not be used to endorse or promote products derived from this software without specific prior written permission. THIS SOFTWARE IS PROVIDED "AS IS" AND WITHOUT ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF MERCHANTIBILITY AND FITNESS FOR A PARTICULAR PURPOSE.

    Portions of this product are based in part on the work of Greg Roelofs. Because Microsoft has included the Greg Roelofs software in this product, Microsoft is required to include the following text that accompanied such software:

    Copyright © 1998-1999 Greg Roelofs. All rights reserved.

    This software is provided "as is," without warranty of any kind, express or implied. In no event shall the author or contributors be held liable for any damages arising in any way from the use of this software.

    Permission is granted to anyone to use this software for any purpose, including commercial applications, and to alter it and redistribute it freely, subject to the following restrictions:

    Redistributions of source code must retain the above copyright notice, disclaimer, and this list of conditions.

    Redistributions in binary form must reproduce the above copyright notice, disclaimer, and this list of conditions in the documentation and/or other materials provided with the distribution. All advertising materials mentioning features or use of this software must display the following acknowledgment:

    This product includes software developed by Greg Roelofs and contributors for the book, PNG: The Definitive Guide, published by O'Reilly and Associates.

    Portions of this software are based in part on the work of Hewlett-Packard Company. Because Microsoft has included the Hewlett-Packard Company software in this product, Microsoft is required to include the following text that accompanied such software:

    Copyright © 1994 Hewlett-Packard Company

    Permission to use, copy, modify, distribute and sell this software and its documentation for any purpose is hereby granted without fee, provided that the above copyright notice appear in all copies and that both that copyright notice and this permission notice appear in supporting documentation. Hewlett-Packard Company makes no representations about the suitability of this software for any purpose. It is provided "as is" without express or implied warranty.

    Portions of this software are based in part on the work of the University of Southern California. Because Microsoft has included the University of Southern California software in this product, Microsoft is required to include the following text that accompanied such software:

    Copyright © 1996 by the University of Southern California. All rights reserved.

    Permission to use, copy, modify, and distribute this software and its documentation in source and binary forms for any purpose and without fee is hereby granted, provided that both the above copyright notice and this permission notice appear in all copies - and that any documentation, advertising materials, and other materials related to such distribution and use acknowledge that the software was developed in part by the University of Southern California, Information Sciences Institute. The name of the University may not be used to endorse or promote products derived from this software without specific prior written permission.

    THE UNIVERSITY OF SOUTHERN CALIFORNIA makes no representations about the suitability of this software for any purpose. THIS SOFTWARE IS PROVIDED "AS IS" AND WITHOUT ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, WITHOUT LIMITATION, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE.

    Portions of this software are based in part on the work of Luigi Rizzo. Because Microsoft has included the Luigi Rizzo software in this product, Microsoft is required to include the following text that accompanied such software:

    © 1997-98 Luigi Rizzo (luigi@iet.unipi.it)

    Portions derived from code by Phil Karn (karn@ka9q.ampr.org), Robert Morelos-Zaragoza (robert@spectra.eng.hawaii.edu) and Hari Thirumoorthy (harit@spectra.eng.hawaii.edu), Aug 1995

    Redistribution and use in source and binary forms, with or without modification, are permitted provided that the following conditions are met:

    Redistributions of source code must retain the above copyright notice, this list of conditions and the following disclaimer. Redistributions in binary form must reproduce the above copyright notice, this list of conditions and the following disclaimer in the documentation and/or other materials provided with the distribution.

    THIS SOFTWARE IS PROVIDED BY THE AUTHORS "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE AUTHORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.

    Portions of this software are based in part on the work of Massachusetts Institute of Technology. Because Microsoft has included the Massachusetts Institute of Technology software in this product, Microsoft is required to include the following text that accompanied such software:

    Copyright © 1989,1990 by the Massachusetts Institute of Technology. All Rights Reserved.

    WITHIN THAT CONSTRAINT, permission to use, copy, modify, and distribute this software and its documentation for any purpose and without fee is hereby granted, provided that the above copyright notice appear in all copies and that both that copyright notice and this permission notice appear in supporting documentation, and that the name of M.I.T. not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. M.I.T. makes no representations about the suitability of this software for any purpose. It is provided "as is" without express or implied warranty.

    Under U.S. law, this software may not be exported outside the US without license from the U.S. Commerce department.

    Portions of this software are based in part on the work of Regents of The University of Michigan. Because Microsoft has included the Regents of The University of Michigan software in this product, Microsoft is required to include the following text that accompanied such software:

    Copyright © 1995,1996 Regents of The University of Michigan. All Rights Reserved.

    Permission to use, copy, modify, and distribute this software and its documentation for any purpose and without fee is hereby granted, provided that the above copyright notice appears in all copies and that both that copyright notice and this permission notice appear in supporting documentation, and that the name of The University of Michigan not be used in advertising or publicity pertaining to distribution of the software without specific, written prior permission. This software is supplied as is without expressed or implied warranties of any kind.