Slashdot Mirror


GPL Code Found In OpenBSD Wireless Driver

NormalVisual writes "The mailing lists were buzzing recently when Michael Buesch, one of the maintainers for the GPL'd bc43xx Broadcom wireless chip driver project, called the OpenBSD folks to task for apparently including code without permission from his project in the OpenBSD bcw project, which aims to provide functionality with Broadcom wireless chips under that OS. It seems that the problem has been resolved for now with the BSD driver author totally giving up on the project and Theo De Raadt taking the position that Buesch's posts on the subject were 'inhuman.'" More commentary from the BSD community is over at undeadly.org.

14 of 671 comments (clear)

  1. Summary: Theo went over the top by Bruce+Perens · · Score: 5, Informative
    This was discussed on Technocrat a few days ago. Apparently the Linux kernel developer did not wish Broadcom to take advantage of his work in proprietary products. Given Broadcom's record of having a number of undocumented, closed-driver-only products that we have to reverse-engineer, and having some proprietary drivers that IMO violate the GPL on the kernel, I can see why he'd feel that way. The BSD developer was an accomplished BSD committer and should have known better. The Linux developer offered to relicense some of his code under BSD. Theo decided to turn it into a human-rights issue with great flamag. The BSD developer walked off in a huff.

    The whole thing lasted two days, much less than the blog and news coverage. Someone will come along and write this driver for BSD, and the BSD developer will have some well-deserved cooling-off time.

    Bruce

    1. Re:Summary: Theo went over the top by Bruce+Perens · · Score: 4, Informative
      Just don't flame on Technocrat.net . Or do flame, and I'll have no problem using that "delete" button in a way that Tio Paco :-) doesn't do here.

      Actually, there is a time and place for flame wars. Justified anger is better than sitting aside while bad stuff happens. But this particular encounter did not justify the anger Theo displayed.

      Bruce

    2. Re:Summary: Theo went over the top by ZorbaTHut · · Score: 3, Informative

      BSD does not require attribution (in fact, that clause was specifically removed.) As long as the license appears somewhere in the project, it's sufficient. (IANAL but this is how I understand it.) On top of that, the BSD license is so open that, if the license did not specify that the license must be included, it really wouldn't be necessary - you can take BSD code and do pretty much whatever you want with it, including add it to a GPL project, or modify it and GPL-license the modifications. (Or, for that matter, not modify it and then provide the original source code under the GPL.)

      The GPL is different in that regards. If I saw GPL code in a BSD project, and the GPL code was not marked as such, I would have no way of knowing that it would be illegal for me to take that code and treat it as BSD code. As such, any GPL code added to a mostly-BSD-licensed project must be marked explicitly as such.

      I don't know what the issue with the Virgin WebPlayer is, but the others are all BSD-licensed code added to a GPL project, which doesn't require any specific notification beyond the BSD license appearing somewhere.

      --
      Breaking Into the Industry - A development log about starting a game studio.
    3. Re:Summary: Theo went over the top by mr_matticus · · Score: 3, Informative

      That's why statutory laws don't say "distribute" alone. They say "distribution or offer for distribution." Manifest intent to commit a crime with tangible evidence (the equivalent of a signed letter stating that you intend to rob bank X on date Y with weapon Z) is more than enough for law enforcement to take action. If you're stopped before anyone gets hurt, you're still charged--the whole IDEA behind law enforcement is to intercept crimes, to punish crimes that have occurred despite those attempts, and to discourage the incentive to attempt those crimes in the first place by virtue of a good track record and a strong fist of justice.

  2. Typo, and more data. by Bruce+Perens · · Score: 3, Informative
    That's "flamage", not "flamag". Sorry.

    And by the way, first post :-) . OK, I'm a subscriber, I guess that's cheating.

    Here is the Technocrat.net discussion of the same issue.

    Bruce

  3. Re:I am amazed by Bruce+Perens · · Score: 5, Informative
    I thought Open Source was about sharing code

    It is. This leaves the question of whether you are OK with some people who refuse to share. If the answer is no, use GPL. If yes, use BSD. You also have the option of using GPL, and asking for money from those who prefer exchanging money over sharing code, as MySQL does with its dual-licensing.

    Bruce

  4. Silly by Bogtha · · Score: 5, Informative

    The crux of Theo's complaint seems to be that they "went public" by emailing too many people. When some of the people in on the email pointed out that they were the ones that actually did the hard work of reverse-engineering, Theo said:

    And how exactly does seeing this public flogging involve you?

    Wow. Just, wow. I often agree with Theo even when he's being a knob because he's usually got a point. But in this case, he's been embarrassed, and he is using whatever he can think of as an incredibly flimsy excuse to attack the people whom the OpenBSD developer plagiarised. What a childish, unproductive attitude. Pulling the code and giving up on the driver instead of taking them up on their offer to relicense the code is cutting off your nose to spite your face, and worse for your users. Just take your ball and go home, Theo.

    --
    Bogtha Bogtha Bogtha
  5. Re:Summary of the Facts by mbuesch · · Score: 5, Informative

    None of these facts are relevant to the discussion. They _are_. Actually, these seem to be the _only_ facts that are relevant to the discussion in the first place.

    Even Jeff Garzik, one of the bcm43xx developers Jeff is not one of the bcm43xx developers. He's the linux net maintainer.

    It's unfortunate that Michael Beusch is more concerned about defending his actions than correcting the injustice. It's interresting that people seem to think _I_ have to apologize, as the OpenBSD developers did the Bad Things in the first place. There's a simple rule: Don't violate copyrights and don't get blamed for it. It's so simple.
  6. Re:The BSD folks seem to be whiners by phoenix.bam! · · Score: 5, Informative

    Except if this was done in private no one who pulled the tainted code from the public CVS would know. There would be copies of the code floating around in public that were in violation of the GPL. It had to be public to guarantee everyone knows (Especially Broadcom) that the BSD code in the public tree is actually GPL code.

  7. Following the E-Mail Thread by theunixman · · Score: 5, Informative

    I managed to catch front-row seats to the whole battle myself. Buesch (the Linux bcm43xx developer) posted a formal but not in any way harsh question to the BSD developer on the public bcm43xx list and to the BSD list. In any language, when communicating in unfamiliar places with unfamiliar people, using more formal dialects is almost always the rule. Some people find the higher dialects offensive, but almost everyone appreciates the attempts to not sound like one of the local street punks hanging out around the corner at the strip mall trolling for some action.

    Apparently the OpenBSD people were put off by this, which is unfortunate. And apparently they were so focused on making it yet another OpenBSD vs The World incident that they completely lost sight of the goal of both projects, which is to create Free and Open drivers for other people to use, despite the hardware specifications not being available. It's an unfortunate situation, of course.

    Hopefully after everyone has a chance to reflect on the situation, the OpenBSD developers will realize that even though many other situations are actually OpenBSD vs The World, this is not one of them, and the Linux bcm-43xx team was not only willing to work with them on relicensing code, they also published the results of an incredible reverse engineering effort for anyone, including the OpenBSD team, to use in order to achieve this goal.

  8. Re:This is the worst possible offense in open sour by rossifer · · Score: 3, Informative

    But he did not copy the code. Rather it was just similar.
    Erm, no. The developer admitted that he copied the code over so that he could make progress on another part of the code. It was his intention to remove the copied code at a later date. By not even leaving any notes in the code about the copy and checking that code into a public cvs repository, the developer made a pretty big (yet fixable) mistake.

    I'll admit it, I've done that very thing (copy some code in order to bootstrap a project). But I put all sorts of comments around tainted code, and I make damned sure that every single line of tainted code is rewritten before that code, or a product based on it, is released into the wild.

    Theo and Marcus both come across as graceless and petulant children. At least Marcus decided to be childish quietly. Theo's ongoing rants about "the inhumanity" of it all just get hysterical after a few posts. Yes, the original email probably should have been more private. But the response from Theo is completely and utterly over the top.

    Regards,
    Ross
  9. Re:Broadcom using bcm43xx code? Hah! by Bogtha · · Score: 5, Informative

    Michael Busch's whole argument that they GPL'ed the damn thing because they didn't want Broadcom to take advantage of their work is BS.

    Of course it is. Of course, most people don't realise this, because the evil, inhuman Michael Busch used his time machine to travel back to 2005 and plant fake mailing list archives saying that the reason they chose the GPL over the BSD license was because they didn't want it taken proprietary especially by Broadcom, because of particular features of the open driver, when we all know it's just an evil, inhuman plot against Theo and OpenBSD. Thanks for alerting us to this deviousness, AC!

    --
    Bogtha Bogtha Bogtha
  10. Re:Broadcom using bcm43xx code? Hah! by osu-neko · · Score: 5, Informative

    How any code from a reverse engineered spec that blatantly just guesses at a lot of things is better than something written with the docs is far beyond me.

    I'm going to venture a guess that you're either not a professional software engineer, or still fresh out of college and very low on real world experience, then. At the very least, you've seen the codebases at very few companies, or you've just been very, very lucky.

    I've had to throw out code and start fresh because the original code I was given was code that had been written originally years ago by an outside contractor brought in to do it, then maintained for the next two years by the hardware engineers themselves, under the premise that they're engineers, they've got a C compiler and a SAMS book, what more qualifications did they need? I was brought in because they couldn't figure out how to add some new features they wanted. The reason wasn't because the new features were tricky, the reason was the code was so hacked up it was impossible to change anything without breaking everything else. Alas, this level of code is all too common at companies that see their primary product as hardware rather than software.

    I've also seen horribly base code that needed to be replaced at companies that had paid software engineers maintaining it the whole time. Why do you think the fact that they were paid software engineers somehow magically makes their code any better? It was crap, and the only reason they were able to get away with it was because no one outside their department ever saw it. There's no easier way to hide bad coding than to work inside a corporation on proprietary software. It's the easiest place in the world for it to occur, and often the hardest place in the world to get incompetent engineers off a project.

    --
    "Convictions are more dangerous enemies of truth than lies."
  11. Trolls on both sides by stsp · · Score: 4, Informative

    First, let me say that I am totally shattered and disappointed. I am doing work in both the Linux and BSD communities, and this is by far one of the most destructive flamewar I have ever witnessed. It will be hard to repair the damage done... This is very sad.

    More commentary from the BSD community is over at undeadly.org.

    It's only fair to note that while there has been lots of stupid flaming on the OpenBSD side as usual, the linux bcw developers, while trying to appear rather nice and careful on the public mailing lists, where laughing their asses off about the whole thing behind the scenes in their IRC channel. They didn't exactly try hard to keep things peaceful either.

    http://bcm-specs.sipsolutions.net/irc-logs/bcm-spe cs.2007-04-03
    http://bcm-specs.sipsolutions.net/irc-logs/bcm-spe cs.2007-04-04
    http://bcm-specs.sipsolutions.net/irc-logs/bcm-spe cs.2007-04-05
    http://bcm-specs.sipsolutions.net/irc-logs/bcm-spe cs.2007-04-06

    Some quotes, the first one actually shows the igniting spark. Others show how people enjoyed watching the flames.I find it disgusting that some people seemed to enjoy watching an already brittle relationship between two deeply related communities fall into pieces. Do they also throw stones at public demonstrations and then go home to watch the riots on telly?

    [20:55] <nbd> when you complain about the license violation, please make it publicly :)<br>
    [20:55] <mb_> I think I should contact them. That's crossing a border. Copying magic register writes is one thing, but copying algorithms is another<br>
    [20:55] Action: nbd thinks this is very blatant<br>
    [20:55] <johill> mail the authors, Cc Theo de Raadt, and bcm43xx and jon (lwn)<br>
    [20:55] <st3> i'dd cc lkml too<br>
    [20:55] <johill> watch the outcry<br>
    [20:55] <st3> for the sake of fun<br>
    [20:55] <mb_> no, not lkml<br> [20:56] <mb_> I don't like stupid replies from retards in my inbox :)
    [20:56] <johill> heh
    [20:56] <mb_> Too many of them subscribed there

    [20:44] <st3> It's too late. He has given up, because of your first mail.
    [20:44] <st3> He has already deleted his work from our tree.
    [20:44] <st3> everybody is crying
    [20:47] <st3> "Too late."
    [20:48] <st3> rotfl
    [20:48] <st3> well, i'm a bit sorry anyway

    [01:40] <johill> nothing
    [01:40] <johill> fluff
    [01:40] <johill> he needs to fill his email with long paragraphs
    [01:41] <johill> (I think he's trying to say that the developer who stole all the code shouldn't really be blamed because he might be too much of a wimp)
    [01:41] <johill> ;)

    [01:51] Action: Newsome laughs at theo complaining about someone being "mean"

    [23:46] <Kaloz> theo is emotional and sensitive guy
    [23:46] <Kaloz> and you are all bastards
    [23:46] <Kaloz> he's now crying in a dark corner :(
    [23:46] <Kaloz> :P
    [23:47] <Kaloz> hey, theo is an emo? :D
    [23:53] <mb_> :D

    [13:33] <Kaloz> I know the bsd morons quite enough.. what always make me laugh that they simply claim whatever software it is, if it's gpl, it's crap and badly coded