PHP Becomes First Programming Language To Add 'Modern' Cryptography Library In Its Core (bleepingcomputer.com)

An anonymous reader writes from a report via BleepingComputer: The PHP team has unanimously voted to integrate the Libsodium library in the PHP core, and by doing so, becoming the first programming language to support a modern cryptography library by default. Developers approved a proposal with a vote of 37 to 0 and decided that Libsodium will be added to the upcoming PHP 7.2 release that will be launched towards the end of 2017. Scott Arciszewski, the cryptography expert who made the proposal, says that by supporting modern crypto in the PHP core, the PHP team will force the WordPress team to implement better security in its CMS, something they avoided until now. Additionally, it will allow PHP and CMS developers to add advanced cryptography features to their apps that run on shared hosting providers, where until now they weren't able to install custom PHP extensions to support modern cryptography. Other reasons on why he made the proposal are detailed here. Arciszewski also says that PHP is actually "the first" programming language to support a "modern" cryptography library in its core, despite Erlang and Go including similar libraries, which he claims are not as powerful and up-to-date as PHP's upcoming Libsodium implementation.

Comments

Oh please

[Anonymous Coward]

Any language where the default equality comparison operator is *true* given two string-type variables with values "0E54321" and "0E12345" is not a cryptographically secure language. In fact there is a nonzero chance of the default equality operator returning true between two different MD5 or SHA256 hashes if they happen to fall into a hexadecimal form that is all digits except for one E or F.

Anyone who claims that PHP is somehow more secure as a language because it has added *new optional library calls* without doing anything about the fundamental language defects is demented.

Re:Oh please

[Vairon]

PHP has a comparison operator === that evaluates if the two things it is comparing are equal and of the same type.

$ php -r "if (\"0E54321\" === \"0E12345\") { echo 'equal'; } else { echo 'not equal'; } "
not equal

Without ===, variable type conversion can cause a string containing numbers to be converted to an integer. See these links for details:

http://php.net/manual/en/langu...
http://php.net/manual/en/langu...

Re:Oh please

[Lisandro]

Except for objects, where a === b is true only if a and b are the same object. Such a beautifully designed language.

Re:Oh please

[Dogtanian]

Any language where the default equality comparison operator is *true* given two string-type variables with values "0E54321" and "0E12345" is not a cryptographically secure language. In fact there is a nonzero chance of the default equality operator returning true between two different MD5 or SHA256 hashes if they happen to fall into a hexadecimal form that is all digits except for one E or F.

Technically, that (in itself) doesn't necessarily mean that the built-in cryptography nor the language itself are inherently insecure. In theory, that is, provided you understand the language and use it correctly.

And that's the problem. Because in practice, PHP's design philosophy of trying to be clever- often too clever by half- when it comes to comparisons, equality, automatic coercion, data types, etc. etc. too often gives unpredictable and unexpected results from people who weren't aware of that behaviour.

You absolutely do *not* want any risk of this happening when you're designing a system that has to be secure. You want boringly explicit and utterly predictable data and type handling.

My prediction is that far, *far* more security holes will be down to bugs caused by unforeseen subtle aspects- i.e. pitfalls- of PHP's type handling and equality behaviour (etc.) in the apps using it rather than bugs in the cryptographic module itself.

PHP being a language more favoured by inexperienced users, this is likely to be made far worse. Expect lots of newbies with misplaced confidence designing what they think are "secure" apps that are in fact full of holes- either because they've misused or misunderstood the cryptographic module, or because they've overlooked some basic aspect of computer security elsewhere (e.g. failure to parse input securely) that makes the use of cryptography irrelevant.

And those are the sorts of mistakes newbies would make when using any language- with PHP's language design issues on top of that, it has the potential to be far worse.

So, yeah. I trust that the module will be secure. The main problems- I guarantee- will be caused by caused by overlooked (or not known about) aspects of PHP's too-clever-by-half data handling (in client apps using it) leading to exploitable holes, and by the fact that too many of PHP's newbie-skewing userbase will overconfidently assume it makes their apps foolproof while using it incorrectly and ignoring security holes elsewhere that make it redundant.

Re:Oh please

[fahrbot-bot]

PHP has a comparison operator === that evaluates if the two things it is comparing are equal and of the same type.

The next version will support "====" for things are really, *really* equal.

Re: Oh please

[Edgewize]

Or more relevantly, I think this is what the original poster was referring to:
https://www.whitehatsec.com/bl...

Here are some examples of PHP doing mind boggling things with md5 and sha1 hashes.

https://3v4l.org/tT4l8

Re:Oh please

[gweihir]

It is a poor craftsman that uses shoddy tools in the first place. Selecting good tools is a core skill for any craftsman. Those that do not have it will never amount to anything.

SubjectsSuck

[aardvarkjoe]

Arciszewski also says that PHP is actually "the first" programming language to support a "modern" cryptography library in its core, despite Erlang and Go including similar libraries, which he claims are not as powerful and up-to-date as PHP's upcoming Libsodium implementation.

So it's the first to support a modern cryptography library, as long as you define "modern" to mean "the one that we're using."

It's easy to be first to do something if you place enough arbitrary restrictions on what that something is.

Re:So they'll be the first to do it wrong?

[c]

I'll stick to every other language that has had libsodium bindings for a while now.

I'm just waiting for them to release the libsodium bindings for C...

Other languages did this first

[MobyDisk]

I remember when Java was the first language to do this. Shortly after that, C# was the first language to do this. Now PHP is the first language to do this. So who will be the next one to do it first?

So, you're embedding libsoduim...

[Lisandro]

...which effectively prevents me from updating it. Great choice for a security library guys.

And it'll be a shitshow because of course it is

[Just Some Guy]

Sneak preview of the API:

crypto_really_encode(plaintext, algorithm); // Simplest
crypto_really_encode(plaintext, mode, algorithm); // Next arg goes in the middle
crypto_really_encode(block_size, plaintext, algorithm, mode); // Switch it up yo lol

...where AES will somehow be a valid value for both mode and algorithm (which will silently override to "NULL" if plaintext starts with a zero or the letter "p").