Slashdot Mirror


User: Craftse

Craftse's activity in the archive.

Stories
0
Comments
3
First seen
Last seen
Profile
(view on slashdot.org)

Comments · 3

  1. Code review on RIAA Plans Cyberwar Effort · · Score: 1

    First off, you should probably pre-increment/decrement your variables rather than post-incrementing/decrementing them. Pre-incrementing actually increments the varable, rather than creating a new variable, copying the old variable's data over, incrementing it, changing the pointer to the new variable, and then freeing the memory from the old variable.

    Second, you used the assignment operator in your while statements rather than the comparison operator. This will cause the loops to run infinitely.

    Third, in the for loop, illegalMusicCount may begin with a value greater than zero, in which case the loop would not run. If it did, it would be with a value of zero for illegalMusicCount, thereby not entering the if statement at all. You should probably use the != operator in the for loop instead.

    Fourth, the ^ operator is the bitwise XOR operator. Assuming you used a 32-bit integer, you just XORed lawsuitRevenue with 00000000000000000000001111101000 (binary). Unless you initialized lawsuitRevenue to be some non-zero/non-one value, any exponential modification would either take on some unforseeable result (if it was not initialized) or zero or one (if it was initialized to either of those, respectively). You should also check to see how large a value you're getting. Taking something to the thousandth power repeatedly is a good way to overflow whatever you're using to store values with if it can run a large number of times (such as with somebody who is a frequent MP3/OGG downloader/rippper and has tens of thousands of music files).

  2. Re:Results on EFF Files First Anti-DMCA Lawsuit · · Score: 1

    Excuse me, but how is this flamebait? "It's funny. Laugh."

  3. Another IBM/Linux ad? on IBM's Upcoming Linux Ad Campaign · · Score: 1

    IBM already made a Linux ad. AFAIK, it never made it to TV, though.