Slashdot Mirror


Unreal Engine Code Issues Fixed By Third-party Company

An anonymous reader writes: Unreal Engine is the famous game engine that was used to implement such games as Unreal Tournament, BioShock Infinite, Mass Effect and many more. On March 19, 2014 Unreal Engine 4 was made publicly available from a GitHub repository. It was a big event for the game development industry. One of the companies that took an interest in this was PVS-Studio, who created a static C/C++ code analyzer. They analyzed the Unreal Engine source code and reported to Epic Games's development team about the problems they found. Epic suggested a partnership with PVS-Studio to fix those bugs, and their challenge was accepted. Now, PVS-Studio shares their experience in fixing code issues and merging corrected code with new updates in a major project that shares its source code.

12 of 72 comments (clear)

  1. Re:Problems causing Video effects? by Anonymous Coward · · Score: 3, Insightful

    Of course they can. If you calculate stupid stuff, the result will be stupid stuff.

  2. Slashvertisment by Dunbal · · Score: 4, Insightful

    Why do I feel like this is an ad for the code analyzer?

    --
    Seven puppies were harmed during the making of this post.
    1. Re:Slashvertisment by TFlan91 · · Score: 2

      Let me quote:

      "This activity benefits everyone: readers enjoy learning from others' mistakes and discover new means to avoid them through certain coding techniques and style. For us, it's a way to have more people learn about our tool. As for the project authors, they too benefit by gaining an opportunity to fix some of the bugs."

      I added the bold.

    2. Re:Slashvertisment by turp182 · · Score: 4, Informative

      I believe you didn't read the link. It was written by PVS staff, and states very clearly that the effort was to promote their product:

      As a way of promoting our PVS-Studio static code analyzer, we've thought of an interesting format for our articles: We analyze open-source projects and write about the bugs we manage to find there.

      They made it to Slashdot, so the effort was a success on some level. And maybe more people need to be aware of code analyzers (we just enforce code conventions and obvious bad practices).

      --
      BlameBillCosby.com
    3. Re:Slashvertisment by UnknownSoldier · · Score: 4, Informative

      The one review everyone is interested in ... Linux Kernel (Jan 2015) static analysis!

      Other notable ones are:

      * LibreOffice
      * Vim
      * Gimp
      * Wine
      * Blender
      * Quake 3 Arena
      * Doom 3
      * Notepad++ (2012)

  3. Re:Problems causing Video effects? by sexconker · · Score: 2

    Only idiots "tend to blame drivers" for that shit.
    The vast majority of changes in driver updates for AMD and nVidia are hacks for specific games to fix their broken shit and get them to not run like ass.

  4. Re: Problems causing Video effects? by donscarletti · · Score: 3, Interesting

    You don't know what you are talking about. Drivers never quite follow the DirectX, OpenGL spec and always have some idiosyncrasies on this card or that to make them generate correct-ish results faster by cutting corners. I find my card getting completely different results to the reference implementation on a monthly basis (sometimes even missing draw calls completely or rendering with the wrong state). I found this particularly true when using DX9 style render states on DX11 class hardware. Neither AMD nor Nvidia will change a driver for you unless you can prove to them that the application is using the spec correctly and the observed results are demonstrably wrong. If you are an independent developer it's even worse since they don't make it easy to contact them.

    --
    When Argumentum ad Hominem falls short, try Argumentum ad Matrem
  5. Re: It's an advertisement for their PVS Studio pro by donscarletti · · Score: 2

    It does make a good case for their product. I look at most of that stuff and think "I have done that" and think how much time has been wasted diagnosing such bugs.

    However, what concerns me is the potential noise that is not in the article. I am pretty sure there are a few things that it reports that are actually OK and these things weren't included. Though I admit that I don't know for certain this is the case.

    --
    When Argumentum ad Hominem falls short, try Argumentum ad Matrem
  6. Re:Problems causing Video effects? by Anonymous Coward · · Score: 2, Informative

    Should have used OpenBSD. Freeing a object gets that memory address nuked immediately. Great dev platform for finding bugs because they do everything they can to make undefined behavior break instead of work most of the time.

  7. Re:Problems causing Video effects? by drinkypoo · · Score: 4, Informative

    The big question for me is do coding errors affect video rendering issues?

    Sure. Just remember that the video driver is a whole bunch of code. It's code all the way down.

    --
    "You're right," Fisheye says. "I should have set it on 'whip' or 'chop.'"
  8. Re:Problems causing Video effects? by Zardus · · Score: 4, Interesting

    A long time ago, I set up Siege of Avalon (at that point, already a 5 year-old game) and, upon getting to some specific level, found that performance had gone down the toilet. I fiddled around for a while, then (for some reason) called the support number. They told me to update my video card drivers. I told them that the video card drivers were already about 4.5 years newer than the game itself, and so their suggestion made no sense. We debated for a while, but they stuck to their guns. I hung up, frustrated.

    Updating my video card drivers fixed the issue.

    --
    You can mod your friends, you can mod your nose, but you can't mod your friend's nose.
  9. Re:Problems causing Video effects? by allcoolnameswheretak · · Score: 2

    At least the part about:

    The vast majority of changes in driver updates for AMD and nVidia are hacks for specific games to fix their broken shit and get them to not run like ass.

    Is quite true I'm afraid. NVidia frequently releases "Game Ready" drivers tuned for a specific game. Usually for high-profile new game releases, such as the Witcher 3 most recently.

    This most recent batch of new "Game Ready" drivers fucked up my and other users systems by frequently crashing, causing the driver and the display to reset, sometimes even on the desktop while browsing. Sometimes this happens multiple times within a minute, rendering some games unplayable. This is one of the threads on the latest clusterfuck on this issue: NVidia display driver stops responding.

    Still no fix from NVidia.