Code Review of Doom For the iPhone

Developer Fabien Sanglard has written a code review for id Software's iPhone port of Doom. It's an interesting look into how the original 1993 game (which he also reviewed to understand its rendering process) was adapted to a modern platform. "Just like Wolfenstein 3D, Doom was rendering a screenframe pixel per pixel. The only way to do this on iPhone with an acceptable framerate would be to use CoreSurface/CoreSurface.h framework. But it is unfortunately restricted and using it would prevent distribution on the AppStore. The only solution is to use OpenGL, but this comes with a few challenges: Doom was faking 3D with a 2D map. OpenGL needs real 3D vertices. More than 3D vertices, OpenGL needs data to be sent as triangles (among other things because they are easy to rasterize). But Doom sectors were made of arbitrary forms. Doom 1993's perspective was also faked, it was actually closer to an orthogonal projection than a perspective projection. Doom was using VGA palette indexing to perform special effect (red for damage, silver for invulnerable...)."

Comments

Re:Already done

[Anonymous Coward]

When in slashdot, nerds dont RTFA.

Re:Already done

[VShael]

did you even read the article?

You must be new here...

Pushing pixels

[MtHuurne]

Forgive my ignorance, but couldn't you have the original software renderer write to an in-memory buffer and then upload that using glTexSubImage2D()?

Re:Pushing pixels

[pananza]

Nah, too easy and direct approach.

Re:Pushing pixels

[Lord Pillage]

Or glWritePixels() would work too. Might be a little bit closer to the original method. But then again, I didn't RTFA, so I wouldn't know.

Re:Pushing pixels

[RedK]

glDrawPixels is not supported under OpenGL ES which is what the iPhone uses. An in-memory buffer used as a texture is about the only way for fullscreen images (vertex arrays drawn using GL_POINTS is another solution but would not be fast enough).

Classics never die

[adosch]

I remember playing Doom in the mid-90's on my friend's Gateway 2000 Pentium 100Mhz. I still play it to this day from time to time (openGL port on Linux). It's mindless, self-indulging, gory, non-challenging (now, not then!), and it's becoming one of timeless those FPS games that won't die because it's story line is simple and not drug out, you're thrown right into the mix and you can keep your objective as simple as you want: Make it to the end of the map.

Re:Classics never die

[goldaryn]

It's mindless, self-indulging, gory, non-challenging (now, not then!), and it's becoming one of timeless those FPS games that won't die because it's story line is simple and not drug out,

In my opinion, DOOM was a good game but it wasn't ground breaking in the same way that Quake was a few years later. It was the first FPS to do real 3D, and gave birth to real FPS competitive play, based on the groundwork that DOOM did with FPS LAN play. Aside from that, the Quake engine led to all sorts of interesting gamemodes and mods that live with us still (Team Fortress was originally a Quake mod), and the physics of Quake 1 still has a legacy today (rocket jumping, bunny hopping).

I think the insurgence of DOOM ports to phones is because the pseudo 3D interface of DOOM lends itself more to the controls of mobile devices. It'd be nice to see more Quake and Duke3D ports.

Re:Classics never die

[Hadlock]

DOOM was a good game but it wasn't ground breaking in the same way that Quake was a few years later. It was the first FPS to do real 3D, and gave birth to real FPS competitive play, based on the groundwork that DOOM did with FPS LAN play. Aside from that, the Quake engine led to all sorts of interesting gamemodes and mods that live with us still (Team Fortress was originally a Quake mod), and the physics of Quake 1 still has a legacy today (rocket jumping, bunny hopping).

You sir, have a career in video game blogging! Let me sign you up for a 3000 word "Top 10 Groundbreaking games of the 1990s" blog entry.

Re:Classics never die

[goldaryn]

Aside from that, the Quake engine led to all sorts of interesting gamemodes and mods that live with us still

I forgot to say: Action Quake was another Quake 1 mod, which eventually became Counter Strike.

Re:Classics never die

[jaggeh]

It was S.E.A.L. Quake not Action Quake

Although my favorite quake mod was malice.

Re:Classics never die

[Antiocheian]

The groundbreaking REAL 3d game was Ultima Underworld. Amazing story, great music and paced to the action (due to midi synthesis) and total 3d immersion.

Pay your respects to Looking Glass.

Re:Classics never die

[imakemusic]

it's story line is simple and not drug out

Unlike, say, Pacman in which the main character spends the entire game eating pills.

I think the word you're looking for is 'dragged'.

Re:Classics never die

[Sir_Lewk]

It added a whole new kind of depth to the gameplay. Suddenly, the game wasn't just about how well you could aim, and how well you knew the maps and where the pickups where, it also mattered how good you were at moving. It was so influencial and loved, that future quake engines made it a point to allow alternative movement styles, the pro mods (CPMA stands out in particular) enhanced and added movement tricks, and entire mods were created around completely around the concept (DeFragged). The quakes were really the perfect games for FPS fans, you could pick them up easily enough because the basics were simple and the weapons were easy to use, but there were always more ways that you could improve your gameplay. If you mastered killing people with weapons, and memorized all of the maps, you cou always find better ways around the maps with the weapons.

The concepts developed in Quake I-III helped make those games legend and have made a presence in nearly every FPS since then. Now I understand that in some gaming circles, movement tricks are look down upon, somehow seen as cheating or as degrading to other peoples gaming experiances in general. I've heard of people being banned from Modern Warfare 2 servers for being "unrealistic". More than anything, this saddens me, and signifies to me an end of an era where fun and skill were important in gaming, not misguided ideas of realism.

Re:Classics never die

[Anonymous Coward]

....and before doom, a thing that most people seem to forgot..

Re:Classics never die

[gregmac]

This is also in a game where you can get hit by a rocket and live if you have enough health. And take a few hundred bullets from a simple 'machine gun'. And jumping from a ledge 6 times your height? No problem.

If it was realistic, you'd be dead from the first

Bloody Hell

[Anonymous Coward]

I thought it was "Code Review of Doom" for the iPhone not "Code Review" of "Doom for the iPhone".
I've seen some "code reviews of doom". I was looking forward to some juicy ApplePain.
Oh well.

Re:Already done

[sznupi]

What makes articles slashdotted anyway?...

Or is that some mystery not approachable "even" by 6-digiters?

He's wrong though

[Anonymous Coward]

Doom 1993's perspective was also faked, it was actually closer to an orthogonal projection than a perspective projection

Not remotely true; DOOM's perspective is/was perfectly correct (apart from the monsters being billboards, of course - but they were perspective-correct billboards).

The method for achieving perspective is rather unconventional, but the maths works out the same.

Matching up floor and ceiling in an animated view with fake perspective is basically impossible.

[I did a port of DOOM before it was open-source, so I know a thing or two about this.]

Re:He's wrong though

[Anonymous Coward]

You are correct. What TFA probably means is that walls, floors and ceilings are drawn in strips, and that for every strip all the texels are looked up according to a straight line. But that doesn't mean at all that hence Doom just uses an orthogonal projection, since it actually let's things diminish in the distance properly. A lot of real three dimensional games actually linearised texel lookup, but that says nothing at all about the overall projection a game uses. If you want to know what an orthogonal projection looks like, go play Age of Empires. As an added comparison, take a look at Mode 7 tricks on the SNES. You can actually perspectively correctly display a flat surface on it. How is this done? By setting a different orthogonal projection for each (in this case horizontal) line. That does not mean however that games using this therefore use an orthogonal projection, because the parameters are different for each scanline and the overall projection is perspective.

I'd like to read this article

[drinkypoo]

But it won't fit on a 800 pixel wide screen. WTF? I thought it was a code review, not a flash game.

Re:I'd like to read this article

[slim]

You need the Readability bookmarklet.

Re:Already done

[JosKarith]

10,000 geeks hitting a server designed for 1000 connections max. Simultaneously.

These are implementation notes, not a code review

[HisMother]

This isn't a "code review" -- it's a short monograph (with Quicktime movies!) that talks about how Id got DOOM working well on the iPhone. A "code review" is, well, a critique of code, and the style, correctness, and efficiency, thereof.
</pedant>

What's with this CoreSurface licensing restriction

[mikelieman]

The only way to do this on iPhone with an acceptable framerate would be to use CoreSurface/CoreSurface.h framework. But it is unfortunately restricted and using it would prevent distribution on the AppStore.

Now this is what really annoys me. Here are tools. Appropriate tools. But you aren't allowed to use the tools, because what you're going to use them for offends The Gods.

What was that RMS was saying again?

Doom is still incredible

[renrutal]

Heh, I remember playing Doom in my uncle's computer back in 94 as as 9 year old boy, and loved it, adored it.

16 years later, now an employed programmer, I still think it is made of black sorcery and an ingenious amount of coding. That's awesome!

Does Carmack /id Soft have a donation paypal-esque account? I'd love to give them what is due for all those early years of pure fun.

Re:Doom is still incredible

[shutdown -p now]

You can still buy id classics on e.g. Steam.

Re:What's with this CoreSurface licensing restrict

[slim]

What was that RMS was saying again?

Don't bring attention to RMS's pragmatism. It confuses those who prefer to think of him as a hippy.

Re:What's with this CoreSurface licensing restrict

[Fahrvergnuugen]

Disallowing the use of private APIs ensures that your software will continue to function with new versions of the iPhone OS. The private APIs might change, but the public ones will not. The real questions is whether or not there should be a public API for CoreSurface.

Re:Already done

[EricWright]

There are those who read (and create the /. effect) and those who post. The intersection of those groups is vanishingly small.

Re:Already done

[buanzo]

.\ is the MS-DOS oriented slashdot, right?

Code Review of DOOM

[asylumx]

I think this is how I'll start referring to ALL my code reviews ;-)

Quake 3 code is mostly ready for iPhone now.

[Anonymous Coward]

A long time ago, I ported Quake 3 to windows mobile. Tedious, but it worked reasonably at around 30fps (and deathmatch worked) with OpenGLES acceleration on the Dell Axim x50v enabled with the intel 2700g coprocessor. The code is still out there, but frankly, it wouldn't be kosher for me to push a copy of Quake 3 to the iphone store since i dont have copyright access to the 'assets' of the game and i dont need to get sued or something.

it's a bit useless to gpl your game and not the assets. If iD software wants to use the code for a quake 3 for iphone, they can do so at http://code.google.com/p/q3ce/source/checkout. Should save them some time. Open invite, go right ahead, i can't do anything with it these days anyway.

(and yes, i converted the whole thing from floating point to fixed point using some fun c++ templates, poke around the code to see how it works, it's kinda neat.)