Re:Static Analyzer Run != Code Review
on
PMD Applied
·
· Score: 1
Yes! Yes! Yes!
Having worked in corporate I/S for far too many years now, I understand that the "right thing" is rarely what happens.
I agree with your point that PMD is not a substitute for a REAL code review, undertaken by a small group of talented programmers. Unfortunately, these rarely happen, so PMD starts to be a very useful second line of defense. For the pragmatic among us, using PMD makes much sense. I wish it wasn't so, but I find that it is. If you work in an environment unlike that which I've described, then more power to you.
Actually, the reason that most of my reviews are positive is that I get a very large amount of choice over what I review. When the publisher sends me a copy of their catalog and asks what looks interesting, you can bet that I'm going to pick something that I think I'll like. I'm only human.
That said, I actually did not want to review the Mongrel eBook, but after more than a little persuasion (but no money) from the publicist I did it as a favour.
I really want to agree, but life has too many variables and programming teams even more than that. Add in the rate of change of technology and you have situations where being six months behind on your reading can make the difference between knowing you can do something with your prefered programming language and thinking it's still impossible.
As the reviewer in question here, I can assure you that I actually read the book before deciding if I like it. No... really! I do try to stack the odds in my favour by requesting books that are for subject matters that I'm interested in, but that is no guarantee of wonderfulness.
As the reviewer of this book, I can offer a few observations.
Firstly it's a pretty thankless task. If you're lucky the author will send you a thankyou email. (That's always nice) But, if you slam the book, you can also get hate mail from the author. (Not so nice)
Second, while the books are generally sent to you for free, that's all you get. We don't get paid people! Oh, and lots of polite emails asking if you've had an opportunity to look at the book yet. Translation: hurry up and get writing!
Third, there is just no way to please everyone on Slashdot. Grow some tough ol' skin if you're going to offer up reviews because every man and his dog is going to think that you're lower than a script kiddie.
Fourth, there's no money in this. I created a website to host reviews at and signed up for a google ad account, but I make about $5 a quarter, so I'm not making any extra money on the side.
Fifth. I love reading books and being opinionated, so I love doing this, but it has to be love because there is no money and precious little appreciation.
True, but just because Lua is targeted at the embedded scripting niche, doesn't mean that many people know about it or even think to list it. That's the unusual thing about Lua being listed.
Unqualified? Interesting. Which part of 16 years earning my employment as a programmer and then a technical lead would disqualify me to comment on technical matters?
1. Do not violate the NDA. Just not worth it. It might be evil and unreasonable, but if you violate it, then how does your prospective employer have any faith that you won't do that to them? Answer: they don't.
2. Write some code. Write it at home. Show that to prospective employers. I know that when I've interviewed folks for my employer, I always ask if they have any code samples that they've written outside of work that they would be able to show me. That way, I'm not asking them to break an NDA and they get a chance to show me some code.
3. You do have a website right? Put examples of your code or writing up on your site. Then just give the interviewer your URL. That's what I've done: "Check out simonpeter.com, everything on the site is mine, go wild!" I have articles, code and opinions up there. Feel free to judge me by my website.
I'm with you. I have not owned a TV for nine years now (a small DVD player for the kids... gotta have Blues Clues!:-) and I have not missed it.
I'll even tell you that I feel that I'm more informed about the world than before, because I read more books, read more news on the Internet and listen to more radio programs than before. Mostly the TV is mental chewing gum, it occupies your time while providing very little benefit.
I also like to think that I'm not ignorant, having an I.S. degree and have studied several other fields to similar depth. But, I might be too ignorant to realise how ignorant I am.:-)
Actually, Lands' End (the company) is named after Land's End, the most south-west tip of the United Kingdom. The founder of the company was a transatlantic racing sailor, and Land's End is the start or finish point (depending upon direction) for most transatlantic races.
I am the author and I appologise for forgetting to put a little something about me in the review. My excuse is that I'm too humble, but who knows if you'll buy that?;-)
I am a Java developer with Lands' End. In fact, I was the first Java developer that LE hired, and I've been with the company five years now. I have worked with Java since version 1.0 and was also responsible for the first Java program written at my previous employer (CUNA Mutual Group... Go Credit Unions!:-)
I have a slight relationship with the publishing houses, in so far as they send me books. I have no connection to the authors. I get to keep the book, but there is no payment for these reviews. I am highly opinionated, so if I say that I like a book, then that's the straight dope. Check out my personal website if you want proof of my willingness to express opinions (http://www.simonpeter.com/)
Tell me: If God is all-seeing and all-knowing, then doesn't He know what's going to happen in the future? And if God already knows what's going to happen, doesn't that mean that our destinies are set in stone, and we have no free will?
Can an all-knowing God know the future? If He is truely all-knowing, then the answer would have to be yes.
Do we have no freewill? I This confuses fore-knowledge, freewill and pre-destination. Fore-knowledge is knowing something either before it happens or before it is general knowledge. One person's (or deity's) knowledge of a matter does not automatically take away anothers abilty to act independently. Freewill is the ability to select a course of action or inaction based upon your own preference or motivation. Pre-destination is strictly the perview of all-knowing deity's, in that it is the knowledge that they have of who will choose to do what and where they will end up as a consequence of those decisions.
So, God's fore-knowledge of the freewill decisions that you are yet to make allows Him to know your pre-destination, but you still have freewill. This is either scary or comforting, depending upon whether you think God is pulling for you or out to get you.
(Bear in mind that answering "no" to the first question is an admission that God is not in fact omnipotent.)
Agreed. But I assert that He is all-knowing, so that doesn't present a problem here!:-)
1. 'i' makes a great loop variable. Yes, I know that it hearkens back to the days of Fortran, but it's become a cross-language idiom, so you'll confuse more people than you'll enlighten if you use something else for short loops.
2. I never learned to type and I have 22 years of non-typing experience to draw upon. If I have to choose between thinking and typing, then I'll choose thinking. I get paid to produce software, not bang out words. Besides, I look at the keyboard while I'm typing and my brain fills in what the command line looks like so far including any mistakes that I make. Who needs to look at the screen?:-)
Slashdot Mirror
Yes! Yes! Yes!
Having worked in corporate I/S for far too many years now, I understand that the "right thing" is rarely what happens.
I agree with your point that PMD is not a substitute for a REAL code review, undertaken by a small group of talented programmers. Unfortunately, these rarely happen, so PMD starts to be a very useful second line of defense. For the pragmatic among us, using PMD makes much sense. I wish it wasn't so, but I find that it is. If you work in an environment unlike that which I've described, then more power to you.
Simon (the guy who wrote the review)
Actually, that's a good point. :-)
Actually, I trashed Will Iverson's book on Jakarta Commons and I have the hate mail from the author to prove it!
C ommons.html
http://techbook.info/reviews/IversonApacheJakarta
Actually, the reason that most of my reviews are positive is that I get a very large amount of choice over what I review. When the publisher sends me a copy of their catalog and asks what looks interesting, you can bet that I'm going to pick something that I think I'll like. I'm only human.
That said, I actually did not want to review the Mongrel eBook, but after more than a little persuasion (but no money) from the publicist I did it as a favour.
Simon
I really want to agree, but life has too many variables and programming teams even more than that. Add in the rate of change of technology and you have situations where being six months behind on your reading can make the difference between knowing you can do something with your prefered programming language and thinking it's still impossible.
As the reviewer in question here, I can assure you that I actually read the book before deciding if I like it. No ... really! I do try to stack the odds in my favour by requesting books that are for subject matters that I'm interested in, but that is no guarantee of wonderfulness.
Simon
As the reviewer of this book, I can offer a few observations.
Firstly it's a pretty thankless task. If you're lucky the author will send you a thankyou email. (That's always nice) But, if you slam the book, you can also get hate mail from the author. (Not so nice)
Second, while the books are generally sent to you for free, that's all you get. We don't get paid people! Oh, and lots of polite emails asking if you've had an opportunity to look at the book yet. Translation: hurry up and get writing!
Third, there is just no way to please everyone on Slashdot. Grow some tough ol' skin if you're going to offer up reviews because every man and his dog is going to think that you're lower than a script kiddie.
Fourth, there's no money in this. I created a website to host reviews at and signed up for a google ad account, but I make about $5 a quarter, so I'm not making any extra money on the side.
Fifth. I love reading books and being opinionated, so I love doing this, but it has to be love because there is no money and precious little appreciation.
Simon
True, but just because Lua is targeted at the embedded scripting niche, doesn't mean that many people know about it or even think to list it. That's the unusual thing about Lua being listed.
Unqualified? Interesting. Which part of 16 years earning my employment as a programmer and then a technical lead would disqualify me to comment on technical matters?
Also, the link you gave for my blog is actually my personal website http://www.simonpeter.com/ my blog is hosted at blogspot. http://uab.blogspot.com/
Just a couple of thoughts:
1. Do not violate the NDA. Just not worth it. It might be evil and unreasonable, but if you violate it, then how does your prospective employer have any faith that you won't do that to them? Answer: they don't.
2. Write some code. Write it at home. Show that to prospective employers. I know that when I've interviewed folks for my employer, I always ask if they have any code samples that they've written outside of work that they would be able to show me. That way, I'm not asking them to break an NDA and they get a chance to show me some code.
3. You do have a website right? Put examples of your code or writing up on your site. Then just give the interviewer your URL. That's what I've done: "Check out simonpeter.com, everything on the site is mine, go wild!" I have articles, code and opinions up there. Feel free to judge me by my website.
Hope this helps,
Simon
I'm with you. I have not owned a TV for nine years now (a small DVD player for the kids ... gotta have Blues Clues! :-) and I have not missed it.
:-)
I'll even tell you that I feel that I'm more informed about the world than before, because I read more books, read more news on the Internet and listen to more radio programs than before. Mostly the TV is mental chewing gum, it occupies your time while providing very little benefit.
I also like to think that I'm not ignorant, having an I.S. degree and have studied several other fields to similar depth. But, I might be too ignorant to realise how ignorant I am.
You found me out! :-)
Actually, Lands' End (the company) is named after Land's End, the most south-west tip of the United Kingdom. The founder of the company was a transatlantic racing sailor, and Land's End is the start or finish point (depending upon direction) for most transatlantic races.
Good question.
;-)
... Go Credit Unions! :-)
I am the author and I appologise for forgetting to put a little something about me in the review. My excuse is that I'm too humble, but who knows if you'll buy that?
I am a Java developer with Lands' End. In fact, I was the first Java developer that LE hired, and I've been with the company five years now. I have worked with Java since version 1.0 and was also responsible for the first Java program written at my previous employer (CUNA Mutual Group
I have a slight relationship with the publishing houses, in so far as they send me books. I have no connection to the authors. I get to keep the book, but there is no payment for these reviews. I am highly opinionated, so if I say that I like a book, then that's the straight dope. Check out my personal website if you want proof of my willingness to express opinions (http://www.simonpeter.com/)
Hope this helps, and I'll put in a bio next time.
Simon
Tell me: If God is all-seeing and all-knowing, then doesn't He know what's going to happen in the future? And if God already knows what's going to happen, doesn't that mean that our destinies are set in stone, and we have no free will?
Can an all-knowing God know the future? If He is truely all-knowing, then the answer would have to be yes.
Do we have no freewill? I This confuses fore-knowledge, freewill and pre-destination. Fore-knowledge is knowing something either before it happens or before it is general knowledge. One person's (or deity's) knowledge of a matter does not automatically take away anothers abilty to act independently. Freewill is the ability to select a course of action or inaction based upon your own preference or motivation. Pre-destination is strictly the perview of all-knowing deity's, in that it is the knowledge that they have of who will choose to do what and where they will end up as a consequence of those decisions.
So, God's fore-knowledge of the freewill decisions that you are yet to make allows Him to know your pre-destination, but you still have freewill. This is either scary or comforting, depending upon whether you think God is pulling for you or out to get you.
(Bear in mind that answering "no" to the first question is an admission that God is not in fact omnipotent.)
Agreed. But I assert that He is all-knowing, so that doesn't present a problem here! :-)
1. 'i' makes a great loop variable. Yes, I know that it hearkens back to the days of Fortran, but it's become a cross-language idiom, so you'll confuse more people than you'll enlighten if you use something else for short loops.
:-)
2. I never learned to type and I have 22 years of non-typing experience to draw upon. If I have to choose between thinking and typing, then I'll choose thinking. I get paid to produce software, not bang out words. Besides, I look at the keyboard while I'm typing and my brain fills in what the command line looks like so far including any mistakes that I make. Who needs to look at the screen?
Is a White Hat Attorney one who works for the EFF or can any non-ambulance chaser qualify?