Slashdot Mirror


No, It's Not Always Quicker To Do Things In Memory

itwbennett writes: It's a commonly held belief among software developers that avoiding disk access in favor of doing as much work as possible in-memory will results in shorter runtimes. To test this assumption, researchers from the University of Calgary and the University of British Columbia compared the efficiency of alternative ways to create a 1MB string and write it to disk. The results consistently found that doing most of the work in-memory to minimize disk access was significantly slower than just writing out to disk repeatedly (PDF).

68 of 486 comments (clear)

  1. The new antipattern by ubergeek65536 · · Score: 3, Funny

    Sorry but you'll need to do it without using any memory. We need to make it fast.

    1. Re:The new antipattern by Anonymous Coward · · Score: 5, Insightful

      Sorry but you'll need to do it without using any memory. We need to make it fast.

      Memory bandwidth is about 20Gb/s. Disk bandwidth is about 0.05Gb/s. The performance consequences of this are obvious to anyone who knows how basic arithmetic works.

      The results they got are invalid because their test framework is broken. This is exactly why everyone should be forced to learn C/C++ or Assembler in college/university. The reason for the crap result is they did not preallocate their buffers so they wasted all their execution time allocating and reallocating larger buffers from the heap. The disk APIs have their own internal buffer implementations, that were not written by idiots, that manage this correctly which is the cause of the difference.

  2. Check their work or check the summary? by s.petry · · Score: 4, Insightful

    'll have to dig through their testing and methods, but this seems pretty fishy given the summary.

    Seek/Read/Write time of a disk is always slower than memory. No exceptions to the rule exist given current commodity hardware. Bus length to a disk is also much longer than to memory. Again, there are no exceptions given commodity hardware.

    Won't be the first time someone reported that the laws of physics don't exist for something, and I'm sure it won't be the last. Maybe someone with free mornings in the US can break it down better than the summary.

    --

    -The wise argue that there are few absolutes, the fool argues that there are no probabilities.

    1. Re:Check their work or check the summary? by LordLimecat · · Score: 4, Interesting

      Tl; DR:

      They used python and java. Sort of hard to develop a meaningful thesis on general programming when you're that far up the abstraction stack. Who knows, maybe python and Java suck at memory management (GASP).

    2. Re:Check their work or check the summary? by s.petry · · Score: 2

      Not to Karma whore, but I already see two problems with their testing by reading their code samples. Lets see who else finds them. The simple answer is no, disk is not slower than memory. The long answer is yes, programmers can make it look that way.

      --

      -The wise argue that there are few absolutes, the fool argues that there are no probabilities.

    3. Re:Check their work or check the summary? by s.petry · · Score: 2, Insightful

      read their code, you will see the problems.

      --

      -The wise argue that there are few absolutes, the fool argues that there are no probabilities.

    4. Re:Check their work or check the summary? by Frnknstn · · Score: 5, Interesting

      It's not even the choice of tools, they seem to willfully misuse the languages to get poor results.

      --
      If it's in you sig, it's in your post.
    5. Re:Check their work or check the summary? by Anonymous Coward · · Score: 2, Informative

      You don't even have to read the code. Reading what languages they used reveals the entire flaw. They used languages with expensive string operations when done in-memory which is the only reason why writing to a buffered cache and writing to disk is faster.

    6. Re:Check their work or check the summary? by Anonymous Coward · · Score: 5, Insightful

      Let me guess

      1. They used "" + "" instead of StringBuilder
      2. They didn't actually flush the file bytes to disk, so it's really a comparison of stupid programmer in-memory string cat and intelligence caching of file writes.
      3. They intentionally engineered a scenario that reported data that was contrary to reality in order to get clicks

    7. Re:Check their work or check the summary? by s.petry · · Score: 2

      Yup yup, I wrote something contrary to my original post quite unintentionally. Memory is always faster than Disk, unless you write shit tests that behave abnormally to make a bogus claim.

      --

      -The wise argue that there are few absolutes, the fool argues that there are no probabilities.

    8. Re:Check their work or check the summary? by bondsbw · · Score: 5, Informative

      Specifically, the time measured to write to memory uses the following code:

        for (int i=0; i < numIter; i++) {
                concatString += addString;
        }

      The time measured to write to disk uses the following code:

        for (int i=0; i < numIter; i++) {
                writer.write(addString);
        }
        writer.flush();
        writer.close();

      In Java, strings are immutable. Each string concatenation produces a new string on the heap, and the old string is unchanged. So there are numIter strings created in memory, and I assume garbage collection will probably happen at some point once enough memory is used. O(n) reads and O(n) writes to the heap with O(n^2) memory usage plus an unknown number of garbage collections. This can cause considerable slowing of the in-memory algorithm.

      That algorithm is then compared with one that does numIter writes to a buffer, which is then flushed to disk at the end. O(n) writes to memory buffer (no need to re-read memory) using O(n) memory space, followed by O(1) writes to disk and O(n) disk space used.

      Granted, it's been over a decade since I took algorithms so I wouldn't doubt that someone can show how I am off, but this kind of thing should be simple to spot for anyone who has an undergrad CS degree.

      PS - I love how the paper makes this aside as if it doesn't matter tremendously:

      Java performance numbers did not change when the concatenation order was reversed in the code in Appendix 1. However, using a mutable data type such as StringBuilder or StringBuffer dramatically improved the results.

      --
      All my liberal friends think I'm a conservative, all my conservative friends think I'm a liberal.
    9. Re:Check their work or check the summary? by danlip · · Score: 5, Interesting

      The language is not the problem, the code is terrible. They did String concatenation in the most expensive way possible. I'm pretty sure if you used a pre-sized StringBuilder it would be faster in memory.

      They also make some very novice benchmarking mistakes.

      This is actually a pretty good interview problem. Anyone who writes code like that should not be hired, even for a junior position.

    10. Re:Check their work or check the summary? by gstoddart · · Score: 2

      I think what they've proven is that there are so many layers in modern programming languages that most of what programmers do because it seems like a good idea probably generates terrible outcomes.

      This actually explains a lot about modern programs, and how 5 years later a machine with twice the resources takes the same amount of time to do something as 5 year old software.

      Because the bloat and inefficiencies added in those five years offset any other improvements. :-P

      --
      Lost at C:>. Found at C.
    11. Re:Check their work or check the summary? by halivar · · Score: 4, Insightful

      And this is why we should not teach CS101 in Java or Python. If they'd been forced to use C this whole experiment would have turned out differently. Even the professors are getting lazy, now.

    12. Re:Check their work or check the summary? by Jerry+Atrick · · Score: 2

      The direct disc write should also manages to overlap write to the stream object with flushes from it to the underlying drive. Except of course it doesn't because they aren't writing enough data for the disc write to actually start before they're done. I'm also a little confused about why they think flush+close is synchronous, it's going to return instantly and flush data in the background. So they aren't even timing what they think they are.

      Back in the world of programmers with a clue, I did fix an in-memory piece of insanity like this not long ago. Making buffer expansion allocations more aggressive got a 10,000x speed improvement.

      Dumb concatenation is for lazy or dumb programmers. Programmers that lazy probably could benefit from using more efficient append ops in the streaming libs, even if they don't understand why it works.

    13. Re:Check their work or check the summary? by Anonymous Coward · · Score: 2, Interesting

      Fixed their code by using a StringBuilder and moving the flush call inside the loop, so it actually writes it to disk.
      The result:

      In-memory mean: string time 0.008900000000000002
      In-memory mean: file time 0.0034000000000000002
      Disk-only mean: file time 1.1747

      Yes, it's still quicker to do things in memory, you just have to do it right.

      PS: with just one flush:
      In-memory mean: string time 0.0091
      In-memory mean: file time 0.0038000000000000004
      Disk-only mean: file time 0.026599999999999995

      Still faster in memory.

    14. Re:Check their work or check the summary? by bwcbwc · · Score: 2

      And there goes another grad student's research thesis up in smoke. CS departments need to have more courses that distinguish between abstract theory (raw algorithms) and software engineering (practical effects of choosing specific languages and features). It's clear the authors of this are in an ivory tower where every string type is the same type of construct in every language.

      --
      We are the 198 proof..
    15. Re:Check their work or check the summary? by Lunix+Nutcase · · Score: 2

      Except any half-decent Java developer uses Stringbuilder not + concat because everyone knows the latter is slower and causes more to be objects created. The only thing they proved is by purposefully doing something wrong you can make it crappy.

    16. Re:Check their work or check the summary? by Anonymous Coward · · Score: 3, Informative

      Changed Java code to use StringBuilder instead of String += String. Results on my machine:
      1: 0.010625
      10: 0.002375
      100: 0.001

      Maybe somebody who study Chemical and Biological Science is not good developer

    17. Re:Check their work or check the summary? by Coryoth · · Score: 2

      And this is why we should not teach CS101 in Java or Python. If they'd been forced to use C this whole experiment would have turned out differently.

      Not at all. If you wrote your C in memory string handling as stupidly as they wrote the Python and Java you will still get worse performance in C (e.g. each iteration malloc a new string and then strcpy and strcat into it, and free the old string; compared to buffered file writes you'll lose). It's about failing to understand how to write efficient code, not about which language you chose.

    18. Re:Check their work or check the summary? by Daniel+Hoffmann · · Score: 2

      Looks like someone forgot to use StringBuilder

    19. Re:Check their work or check the summary? by Rakarra · · Score: 3, Insightful

      Not at all. If you wrote your C in memory string handling as stupidly as they wrote the Python and Java you will still get worse performance in C (e.g. each iteration malloc a new string and then strcpy and strcat into it, and free the old string; compared to buffered file writes you'll lose). It's about failing to understand how to write efficient code, not about which language you chose.

      Yes, but we're talking new programmers here. At least in C, you're forced to have to explicitly write inefficient code. New programmers know what malloc does (if they don't, they're behind in their classes). In Java and Python, things are done for you. That can be good! It frees you from a bit of micromanagement. But again, for a new programmer, it's not apparent that they're doing something especially inefficient because the work happens invisibly. It's obvious when you have to malloc() a whole new string buffer in C every time you append to a string. It's less obvious in Java when you just append and the runtime ends up creating a new buffer on the heap for you. ASM is perhaps a bit TOO low-level and weird to start a new programmer on, but I think a full OOP language like Java or scripting language like Python might be too high-level and encourage bad habits to develop. In my CS classes, C hit a pretty good sweet spot.

      Then again, you can program badly in any language, and C has its own perils.

    20. Re:Check their work or check the summary? by OverlordQ · · Score: 4, Informative

      THATS THE ENTIRE POINT OF THIS PAPER.

      It is easy to explain the results: In high-level languages such as Java and Python, a seemingly benign
      statement such as concatString += addString may actually involve executing many extra cycles behind
      the scenes. To concatenate two strings in a language such as C, if there is not enough space to expand
      the concatString to the size it needs to be to hold the additional bytes from addString, then the
      developer has to explicitly allocate new space with enough storage for the sum of the sizes of the two
      strings and copy concatString to the new location, and then finally perform the concatenation. In Java
      and Python strings are immutable, and any assignment will result in the creation of a new object and
      possibly copy operations, hence the overhead of the string operations. The disk-only code, although
      apparently writing to the disk excessively, is only triggering an actual write when operating system
      buffers are full. In other words, the operating system already lessons disk access times. A developer
      familiar with the language and system internals readily notices the causes of this observed behaviour,
      but this behaviour may be easily missed, as indicated by examining similar cases in production code.

      --
      Your hair look like poop, Bob! - Wanker.
  3. This is the dumbest research I've seen this year by MobyDisk · · Score: 5, Informative

    This is the dumbest research I've seen in 2015. There was actually no computation involved -- they just wanted to write a long string to disk. They concluded that adding the superfluous step of concatenating strings in memory, then writing to disk, was slower. Well duh! That's not what memory is for!

  4. Re:It depends by Lunix+Nutcase · · Score: 4, Insightful

    Even the slowest DDR3 SDRAM has more memory bandwidth and magnitudes faster access time.

  5. Re:It depends by greg1104 · · Score: 5, Informative

    SSDs and disk speed have nothing to do with this. None of these writes are hitting disk. All they've shown is that when you cache a write to disk, the operating system might add data to it more efficiently than the slow Python and Java string code can expand a string.

  6. Re:It depends by hcs_$reboot · · Score: 4, Insightful

    RAM *is* faster (by far) than any persistent media 9SSD, HD...). So whatever the test, the algorithm is probably bad,

    --
    Slashdot, fix the reply notifications... You won't get away with it...
  7. No, It's Not Always Quicker To Do Things In Memory by hcs_$reboot · · Score: 2

    No, It's Not Always Quicker To Do Things In Memory

    The title ("No, It's Not Always Quicker To Do Things In Memory") should be modded Flamebait, Troll or similar. If it'd be possible.

    --
    Slashdot, fix the reply notifications... You won't get away with it...
  8. Re:This is the dumbest research I've seen this yea by c · · Score: 2

    Pretty much my thoughts. Writing to disk is slow, but it's also semi-async operation (in that much of the time, the job is offloaded to the I/O subsystem before the write is complete), which generally means the sooner you start writing your results the sooner you'll finish, and if you start early you can do computational work while the I/O is happening rather than spinning wheels while trying to write the whole thing in one go. All they seem to have done is add a pile of latency and may even have introduced other impacts such as garbage collection or VM swap.

    --
    Log in or piss off.
  9. Re:It depends by Carewolf · · Score: 3, Insightful

    on the speed of your memory, and the speed of your disk, SSD's are getting more common.

    No, it doesn't. Memory is faster. If they get a result saying otherwise, they are doing it wrong, and are actually just measuring the performance of the in-memory cache speeding up the simplest implementation vs the performance of their own crappy implementation.

  10. Re:It depends by jedidiah · · Score: 5, Insightful

    A more accurate title would be: "You can be sufficiently stupid with your memory access that it's faster to do disk IO."

    Java is not the only system that can manifest this.

    --
    A Pirate and a Puritan look the same on a balance sheet.
  11. Re:It depends by ShanghaiBill · · Score: 5, Insightful

    Even the slowest DDR3 SDRAM has more memory bandwidth and magnitudes faster access time.

    Indeed. Their results make no sense. They are doing something weird. For instance, their paper says that concatenating a million one byte strings into a single million byte string takes 274 seconds. That should take much less than one second. Their code is listed at the end of the paper, and they seem to be assuming that "flush" means the code is actually written to disk. It does not. It just means the bytes were passed to the operating system.

    The real story here, is that if you don't know how to write code properly, then string concatenation can be really slow.

    Was their paper peer reviewed?

  12. They went full retard. by duhorg · · Score: 2

    Yep, many commenters here got it right: the "study's" authors are doing teh-stupid operations "in memory". This one is so egregious, especially that the ITworld article author fell for it, that I felt it warranted its own dissection post: http://blog.duh.org/2015/03/wh...

  13. Re:It depends by jellomizer · · Score: 3, Informative

    In general writing to RAM is faster than writing to the disk. However there are things that get in the way of both.
    1. OS Memory Management: So you making a small memory string to a big one. So will the os fragment the string, when it comes up to an other systems reserved memory spot. Will it overwrite it (Buffer overflow), will it find a contiguous larger memory block and copy the data there. Will it copy and move the memory slots to a new location away from the memory. Will this be happening preemptively, or when the error condition occurs, will all this stuff happen with a cpu cycle that is not sharing with your app. Also if you are low on memory the system may dump it to the disk anyways.

    2. OS Disk management: A lot of the same concerns that memory management has. However a bunch of small request is easier to find free space, then asking for a larger spot. So they may be more seek time.

    3. Disk Caching: You tell the program to append to the disk. The OS sends the data to the drive, the drive responds back Yea I got it. then the OS goes back to handling your app, in the mean time your drive is actually spinning to save the data on the disk.

    4. How your compiler handles the memory. Data = Data + "STRING" vs. Data+="STRING" vs Data.Append("STRING") vs { DataVal2=malloc(6); DataVal2="STRING"; DataRec->Next = *DataVal2; } You could be spending O(n) time saving your memory where you can be doing in in O(1)

    Now sometime I do change my algorithm to write to the disk vs. handling it in memory. Mostly because the data I am processing is huge, and I much rather sacrifice speed, in order to insure that the data gets written.

    --
    If something is so important that you feel the need to post it on the internet... It probably isn't that important.
  14. Re:It depends by Anonymous Coward · · Score: 5, Funny

    Was their paper peer reviewed?

    It just was. Why do you ask?

    lololol

  15. Re:1MB fits in cache by itzly · · Score: 2

    They forgot to flush their research paper.

  16. Re:It depends by PacoSuarez · · Score: 4, Informative

    [...] For instance, their paper says that concatenating a million one byte strings into a single million byte string takes 274 seconds. That should take much less than one second.

    I didn't RTFA, but after reading this I am certainly not going to. This C++ piece of code takes around 0.01 seconds to run on my computer:

    #include <iostream>
    #include <string>

    void build_string(std::string &s, std::string r) {
        for (int i = 0; i < 1000000; ++i)
            s += r;
    }

    int main() {
        std::string s;
        build_string(s, "a");
        std::cout s.length() '\n';
    }

  17. Stupid is as stupid publishes.... by TiggertheMad · · Score: 5, Insightful

    I just scanned the paper, because their claim seem to be idiotic. It looks like they are appending a single byte on the end of a string in memory and on disk. For the memory operation, this will result in a string copy since strings are immutable, vs. doing a one byte file append onto the disk. The former is increasingly expensive and the latter is a fixed cost, so after infinite operations, the disk cost becomes far less than the memory operation. If this is indeed their claim, and I am not missing something, then they should be collectively slapped for wasting our time by writing this paper. If this is really your use case, write some proper data structures to manage your data in a sane fashion.

    So yes, if you do stupid things, you can make bad engineering decisions look like good ones.

    --

    HA! I just wasted some of your bandwidth with a frivolous sig!
    1. Re:Stupid is as stupid publishes.... by Bengie · · Score: 3, Insightful

      They should follow best practices and use StringBuilder and rerun their tests.

    2. Re:Stupid is as stupid publishes.... by msobkow · · Score: 2

      Java's "StringBuffer" object can deal with concatenating source code fragments to produce 6 million lines of code in under 8 minutes and write it to a 7200rpm HDD on Linux. Java handles string concatenation quite efficiently if you're using the proper data objects instead of naively doing actual string concatenations that require much more buffer re-allocation than simply extending the end point of a buffer that is periodically reallocated with n extra bytes each time. And that's only on a creaky old P4 3.8GHz with DDR2-800 memory.

      I call "bullshit" on the paper.

      --
      I do not fail; I succeed at finding out what does not work.
    3. Re:Stupid is as stupid publishes.... by Dastardly · · Score: 3, Informative

      It is even worse than that. They are using a BufferedWriter for the so called writing to disk portion. So, they are actually comparing the worst possible way to append a String in memory to appending bytes to a bytes buffer and periodically writing that to disk. So, basically comparing two different in memory string appending techniques? When you bring the OS into play it is even less likely to actually show anything having to do with the disk because the OS will write asynchronously.

      My grade: F- and they should be mocked mercilessly until the paper is retracted for being idiotic.

    4. Re:Stupid is as stupid publishes.... by ndykman · · Score: 2

      I strongly encourage people to email the authors and clue them in. Seriously, this makes me angry. If CS doesn't already have a reputation for being completely academic and out of touch. Things like this, no wonder people think you can learn to code in 10 weeks.

  18. python and java by Spazmania · · Score: 4, Informative

    They tested using strings in python and java, both of whose string libraries are very much overweight. And they tested by concatinating strings in a way that requires constant reallocations and memory copies versus pushing data to fixed size disk buffers in the OS cache.

    So... surprise! When writing data sequentially the C implementation of disk buffers is faster than the java and python implementations of strings.

    --
    Moderating "-1, Disagree" is simple censorship. Have the guts to post your opinion.
  19. Re:It depends by Lunix+Nutcase · · Score: 3, Insightful

    Except they don't write to disk. They wrote to an OS controlled buffer. Simply calling flush does not force a disk write. It signals the OS to take control of the buffer.

  20. HOT BREAKING NEWS! by Alsee · · Score: 5, Funny

    NEW SCIENTIFIC DISCOVERY!
    For n equal to one million, an O(n^2) algorithm is slower than an O(n) algorithm. Even when the O(n^2) algorithm is run in RAM, and the O(n) algorithm is disk writes being buffered and optimized by the operating system.

    I'll take my Nobel Prize now, thank you.

    -

    --
    - - You can't take something off the Internet! That's like trying to take pee out of a swimming pool.
  21. Re:This is the dumbest research I've seen this yea by Jaime2 · · Score: 2

    It's dumber than that. They didn't even do it right in Java. There is a note near the end of the paper that says "However, using a mutable data type such as StringBuilder or StringBuffer dramatically improved the results". They didn't present the numbers, but what they really meant was "The performance problems we saw were entirely due to our not using StringBuilder or StringBuffer, this paper shows no meaningful difference in performance between memory-then-disk and disk-only access once the algorithm is fixed."

  22. This is RESEARCH? by orlanz · · Score: 2

    Ok, I read all the other "This is stupid" comments and my jaw kept dropping. I actually felt this was an April fools thing or something similar and that we were all missing something somewhere (and please let me know if I am... I REALLY need to know). I HAD to read the article and underlying paper, cause I just couldn't believe the absolute asinine stupidity of the test, let alone that it was being presented as research, or that the test itself was so flawed! So after all that, had to post. Summary for others, adding my voice to the crowd.

    ----------------
    Assumption: Software Developers avoid disk access cause they believe doing it in memory is faster. This is put in context of BI and bigdata.

    Testing: Create a program representing a common task that can be tested where one uses memory and the other uses diskspace.
    Memory Test:
    1) Create a string in memory.
    2) Add it multiple times into another string
    3) Write second string onto Disk
    4) Flush writes

    Disk Test:
    1) Create a string in memory
    2) Write it multiple times to Disk
    3) Flush writes

    Create code in Python and Java.

    Conclusion: Memory Test is so much slower than Disk Test! Additionally, the languages used have certain quirks to make it worse. Optimization helped a little but only on Linux. Therefore, programmers should reassess and understand their OS and programming languages before assuming this belief which is not true.
    ---------------

    Assumption & Testing idea... very good. I would have loved to know the unknown scenarios where this assumption should be questioned. Especially in the world of click&drag programming for workflows, ETLs, and report writing.

    But from there... its all BS and stupidity. Basically the test tests if replicating the hard drive driver in memory and then using the driver to write to disk is faster than just using the driver to write to disk. Are you bloody serious?!?! That's like testing if 2+2 is greater than 2+0. And that is before we start looking at using Java and Python which do a ton of work in terms of memory management and build all types of stuff around data types. Before the fact that they wrote the Python code WRONG (that's the slow way of doing string or listing concat). So they picked languages that write in memory O(n) extra times for the same data.

    This test would have come to the same conclusions in C, C++, or Assembly! But the folks wouldn't have been able to write code to see the micro second time differences.

    So lets set the record straight. NO developer out there goes out of their way to just write to a memory file if its simply going to flush to disk. Its not worth the extra lines of code, nor the lost CPU cycles in reading them. Especially since most operating systems do this already at multiple points along the data chain at the very low hardware & driver levels! If we have developers like this, we have a ton of bigger problems in software development than this little thing that will be solved by money.

    To test this belief properly, give me a scenario where you reuse the written to disk/memory stuff, transform it, and then write to disk. See which one is slower. If its written properly, you will see that the underlying hardware systems will actually store stuff in cache or memory for you to help you speed it up! If you find proper scenarios where the memory part is slower, please let us know cause that is actually adding to the IT body of knowledge.

    God, as this was BigData related, I was hoping at least something along the lines of "In DB data processing and extract vs extract and client side processing". Give me the points along a curve where one is better/worse than the other. THAT would have been interesting.

  23. Re:It depends by Rakarra · · Score: 2

    Probably not, and sadly this is the problem with current CS tracks in colleges.

    Zero education on hardware gives us CS grads that are inept.

    It's not necessarily that -- I think there's a third layer that doesn't get the attention deserved while people work on end-user applications or tinker building hardware. There's not much attention on operating system design and fundamentals. Your code will usually be dealing with an OS and rarely with the bare hardware, so I'm surprised there's as little attention about operating systems principles and design.

  24. We're all doing it wrong! by jetkust · · Score: 5, Funny

    Maybe we should store our files in memory and load them into the harddrive to do calculations.

  25. Re:It depends by Penguinisto · · Score: 4, Interesting

    That's the very first thing I thought of... what if the code were written in a lower-level language (and not in fucking python or Java!), then made do this task on Windows $latest, OSX $latest, Linux $latest, maybe a resurrected DOS $latest for reference, etc... I mean, it can't be that hard to write this thing in C and port it as needed.

    Doesn't seem very scientific at all otherwise. I mean, are they testing memory versus disk, are they testing memory vs. disk performance in a given specific language, or what? Maybe they just needed to flesh out their abstract a bit more to reflect this?

    --
    Quo usque tandem abutere, Nimbus, patientia nostra?
  26. Re:It depends by sjames · · Score: 4, Insightful

    It makes perfect sense once you read the paper. The conclusion is techniocally correct but deceptive.

    The results apply in the case of Java and Python where strings are immutable objects. They also used buffered I/O handled by libc. When you concatenate immutable strings, you must allocate a new string large enough to hold both parts, then a memcpy from both of the parts is performed to construct it. The parts are eventually garbage collected.

    In contrast, writing to a file with buffered I/O means just copying the additional write buffer to the current end of the buffer and moving updating the accounting information.

    As a result, in both cases, only one actual filesystem transaction takes place writing out the complete string. Thus, the actual practical difference between the two methods is that the 'in memory' version copies the memory around many times while the 'disk i/o' one copies the data once (in multiple steps, but each byte sees one copy).

    That seems like a bit of a no-brainer, but the point is valid because many programmers may deceive themselves into thinking the 'in memory' method is faster because they don't take the file i/o buffering and the way immutable strings are handled into account.

  27. Re:It depends by lgw · · Score: 5, Insightful

    How in the world? Trivially. They're doing it in an O(n^2) way - it's the only explanation.

    If you use string concat library code naively, you can end up "copy the string, add one byte, repeat" easily enough in languages like Java. And it's not exactly breakthrough research to discover that O(n) disk can be faster than O(n^2) memory for large enough n.

    --
    Socialism: a lie told by totalitarians and believed by fools.
  28. Re:It depends by Beat+The+Odds · · Score: 3, Funny

    Was their paper peer reviewed?

    I believe that it may have been beer reviewed.

  29. Re:It depends by Trailer+Trash · · Score: 3, Insightful

    The real story here, is that if you don't know how to write code properly, then string concatenation can be really slow.

    Was their paper peer reviewed?

    I just reviewed it, but frankly, they're not my peers.

    They actually understand the problem and state it near the end of the paper. The issue is pretty simple and when I read the /. summary I knew what the problem was. They're appending single bytes to a string. In both chosen languages - Java and Python - strings are immutable so the "concatenation" is way the hell more complex than simply sticking a byte in a memory location. What it involves is creating a new string object to hold both strings together. So, there's the overhead of object creation, memory copying, etc. Yes, by the time you're done it's a lot of extra work for the CPU.

    I'm going to state this as nicely as I can: what they proved is that a complete moron can write code so stupidly that a modern CPU and RAM access can be slowed down to the extent that even disk access is faster. That's it.

    Even if you wrote this in C in the style in which they did it the program would be slow. Since there's no way to "extend" a C string, it would require determining the length of the current string (which involves scanning the string for a null byte), malloc'ing a new buffer with one more byte, copying the old string and then adding the new character and new null byte. Scanning and copying are both going to require an operation for each byte (yeah, it could be optimized to take advantage of the computer's word length) on each iteration, with that byte count growing by "1" each time.

    The sum of all integers up to N is N(N+1)/2. If N is 1,000,000 the sum is 500,000,500,000. So, counting bytes (looking for null) requires half a trillion operations and copying bytes requires another half trillion operations. Note that "operations" is multiple machine instructions for purposes of this discussion.

    Yeah, modern computers are fast, but when you start throwing around a trillion operations it's going to take some time.

    Writing to disk will be faster for a number of reasons, mainly because the OS is going to buffer the writes (and know the length of the buffer) and handle it much much better. It's not doing a disk operation every time they do a write. If they were to flush to disk every time they would still be waiting for it to finish.

    There are a few notes, here. First, in Java and Python the string object likely holds a "length" value along with the actual character buffer. That would make it faster and not require all the operations the badly written C code that I describe above would require. But the overhead of objects, JVM, interpreter, etc. gets thrown into the mix. Second, if I were doing something like this in C I could keep the string length as part of a struct and at least make it that much faster. The point is that a good programmer wouldn't write code in this manner.

    Anyway, this "paper" proves nothing except that really bad code will always suck. One would have to be an idiot to write anything close to what they've done here in a real-life scenario. I know because I've cleaned up other people's code that's on the level of this junk...

  30. Repeated Java string concatenation is O(n^2)! by FizzyP · · Score: 2

    Concatenating strings one character at a time in Java has QUADRATIC performance (i.e. O(n^2)). If they used the StringBuilder class instead I bet most of their bottlenecks would disappeared. With that class it should be amortized O(n).

  31. Your code sucks by viperidaenz · · Score: 2

    String concatString = "";
      for (int i=0; i numIter; i++) {
      concatString += addString;
      }

    That's going to create 1,000,000 StringBuilder objects, use them to append a single String each, and allocate 1,000,000 new String objects as well

    StringBuilder builder = new StringBuilder(
      for (int i = 0; i numIter; i++) {
      builder.append(addString);
      }
    String concatString = builder.toString();

    I bet $1,000,0000 that code is faster.

    tl;dr; Researchers who don't know who Java works suck at writing Java benchmarks.
    String a = b + c;
    gets translated by the compiler to something like:
    String a = new StringBuilder(a).append(b).toString();

    It's creating a new StringBuilder object, its member variables including a char array, it copies the String passed in to the constructor. Append is probably also expanding the array, which means creating a new array and copying the old one to the new one, then copying the data from b to the end of the new array.
    toString then creates a new String object, copying the data again.

    If you write shit code, you get shit performance.

  32. Re:It depends by TemporalBeing · · Score: 2

    Even if you wrote this in C in the style in which they did it the program would be slow. Since there's no way to "extend" a C string, it would require determining the length of the current string (which involves scanning the string for a null byte), malloc'ing a new buffer with one more byte, copying the old string and then adding the new character and new null byte. Scanning and copying are both going to require an operation for each byte (yeah, it could be optimized to take advantage of the computer's word length) on each iteration, with that byte count growing by "1" each time.

    Actually, you can "extend" a C-style string just fine in C - just replace the NULL byte with another byte. It's a common error in C programs to miss the NULL byte.

    This works because C doesn't do boundary checks and will gladly let you overwrite your stack or heap.

    Unlike Java, C doesn't try to protect you from yourself.

    --
    Truth is like the sun. You can shut it out for a time, but it ain't goin' away. - Elvis Presley (source: imdb.com)
  33. Re:It depends by Trailer+Trash · · Score: 2

    Well, yeah, but that's not going to work consistently. Worst case is if the string is on the stack you'll smash the stack and likely have a memory access error. If it's on the heap you'll likely get the error quicker.

    I wouldn't even think of writing a program in the manner in which their sample was written, but if I was trying to solve their basic "problem" there are better ways to go about it.

  34. Re:It depends by Anonymous Coward · · Score: 2, Informative

    It's exactly this. The Java code they wrote uses String, resulting in an O(n^2) algorithm. A trivial change to StringBuilder would result in an improvement to O(n).

    The paper is just embarrassing.

  35. Re:It depends by gnupun · · Score: 4, Informative

    There's nothing wrong with Java or Python, but the programmer is inexperienced. Java and Python strings are immutable. So, any time they concatenate a single character to an existing string, the Java runtime creates a brand new string, leaving the original string intact (since it is immutable). So if they create a million character string using using million concatenations, guess what, a million new strings are created and that's very slow. A better solution is to use a mutable String aka, StringBuilder.

    But the right solution is to use a small buffer, say 16KB to 100KB in size, fill that with characters and flush that buffer to disk every time it's full. The speed would be same as any other method, but the max memory used is 20x smaller.

  36. Re:It depends by Anonymous Coward · · Score: 5, Insightful

    And they're using BufferedWriter to write to the file which, as the name suggests, is buffering the data *in memory* before writing it.

    So the result of the paper is actually O(n) in memory algorithm outperforms O(n^2) in memory algorithm for data sizes of 1MB. Hardly surprising.

  37. Stringbuilder? Perhaps..... by TiggertheMad · · Score: 2

    Many people are suggesting using string builder, as a easy fix...If you think about this problem, that doesn't solve it as you approach infinite operations, it just pushes the cost crossover point way out (possibly beyond the limits of existing hardware, so it might be practically moot). Since they are doing silly comparisons like this, I would suggest just writing a linked list to store each byte as a counter example that will provide more of an apples to apples comparison. Adding an element to an linked list will have a fixed cost, just like appending a byte to disk will, so after infinite operations, you could demonstrate that memory operations are always going to be faster performing similar tasks when the IO time of memory is faster than disk IO.

    --

    HA! I just wasted some of your bandwidth with a frivolous sig!
  38. Re:It depends by AlejoHausner · · Score: 2
    OK, so the authors are bad programmers and don't understand how string concatenation works. Strings are contiguous arrays, whereas disk files are made up of consecutive blocks, which are accessed through an index. If you want to append to a file, you may add a block, and modify the end of the index. But if you want to append to an array, you are forced to allocate a whole fresh array, because strings use fixed-size arrays.

    On the other hand, Java StringBuffers have amortized O(1) append cost. A StringBuffers occasionally re-allocate themselves to larger pieces of memory, and the amortized cost of an append is O(1).

  39. How the mighty have fallen by ChaoticCoyote · · Score: 2

    Slashdot has fallen far in credibility if it promotes sloppy research like the referenced article.

  40. Re:It depends by ceoyoyo · · Score: 3, Insightful

    One of them looks like a chemical engineering PhD student and the other is a tech, so maybe not. The third is an electrical engineering professor who's supposed to be doing software performance research though. He should definitely know better.

    Although, when I was at the U of C the people doing software stuff in the EE department had some very interesting ways of doing things.

  41. Re:It depends by Pseudonym · · Score: 2

    But the right solution is to use a small buffer, say 16KB to 100KB in size, fill that with characters and flush that buffer to disk every time it's full.

    Which is to say, do what every programming language with buffered I/O does.

    --
    sub f{($f)=@_;print"$f(q{$f});";}f(q{sub f{($f)=@_;print"$f(q{$f});";}f});
  42. Re:It depends by bingoUV · · Score: 2

    But except saying it "dramatically" improves results, the StringBuilder result wasn't worthy of a mention or a compare against disk performance.

    Obviously, like any good "researcher" does, the conclusion was written first and then the "experiment" was performed. Any results contradicting the conclusion have to excluded.

    --
    Bingo Dictionary - Pragmatist, n. A myopic idealist.
  43. Re:It depends by ILongForDarkness · · Score: 2

    Yeah I'd say bad implementation. They could have some performance improvement depending on timings and such though. Messing around in memory + one fairly large (only 1MB so not really but lets say for arguments sake) vs many smaller writes depending on how the OS handles the write requests you might end up hitting the disk cache and then doing work while the disk is busy spinning and actually writing out your changes. With one big write you might end up hitting some limit that makes the thing not fully buffered in cache and have to wait for the disk to actually complete the write.