How New, Polite Linus Torvalds Points Out Bad Kernel Code (phoronix.com)
Linus Torvalds "has shown already for the new Linux 4.20~5.0 cycle he isn't relaxing his standards but is communicating better when it comes to bringing up coding," reports Phoronix, adding "So far it looks like Linus' brief retreat is paying off with still addressing code quality issues -- and not blatantly accepting new code into the kernel as some feared -- but in doing so in a professional manner compared to his past manner of exclaiming himself over capitalized sentences and profanity that at time put him at odds with some in the Linux kernel community."
AmiMoJo quotes their report: Last Saturday he took issue with the HID pull request and its introduction of the BigBen game controller driver that was introduced: the developer enabled this new driver by default. Linus Torvalds has always frowned upon random new drivers being enabled by default in the kernel configuration driver. [H]e still voiced his opinion over this driver's default "Y" build configuration, but did so in a more professional manner than he has done in the past:
We do *not* enable new random drivers by default. And we most *definitely* don't do it when they are odd-ball ones that most people have never heard of.
Yet the new "BigBen Interactive" driver that was added this merge window did exactly that.
Just don't do it.
Yes, yes, every developer always thinks that _their_ driver is so special and so magically important that it should be enabled by default. But no. When we have thousands of drivers, we don't randomly pick one new driver to be enabled by default just because some developer thinks it is special. It's not.... Please don't do things like this.
Phoronix also describes another "kernel oops" testing Torvalds' patience, in which Linus responded tactfully that "What makes me *very* unhappy about this is that if I'm right, I think it means that code was literally not tested at all by anybody who didn't have one of the entries in that list."
AmiMoJo quotes their report: Last Saturday he took issue with the HID pull request and its introduction of the BigBen game controller driver that was introduced: the developer enabled this new driver by default. Linus Torvalds has always frowned upon random new drivers being enabled by default in the kernel configuration driver. [H]e still voiced his opinion over this driver's default "Y" build configuration, but did so in a more professional manner than he has done in the past:
We do *not* enable new random drivers by default. And we most *definitely* don't do it when they are odd-ball ones that most people have never heard of.
Yet the new "BigBen Interactive" driver that was added this merge window did exactly that.
Just don't do it.
Yes, yes, every developer always thinks that _their_ driver is so special and so magically important that it should be enabled by default. But no. When we have thousands of drivers, we don't randomly pick one new driver to be enabled by default just because some developer thinks it is special. It's not.... Please don't do things like this.
Phoronix also describes another "kernel oops" testing Torvalds' patience, in which Linus responded tactfully that "What makes me *very* unhappy about this is that if I'm right, I think it means that code was literally not tested at all by anybody who didn't have one of the entries in that list."
That should be impossible with just a few written words, right?
SJW: Someone who has run out of real oppression, and has to fake it.
Stop focusing on the PERSON, it is IRRELEVANT to the quality of the code.
I miss the old Linus.
That's the stuff that matters.
I do not believe in karma. "Funny"=-6. Do good and forbid evil. Yours, Oft-Offtopic Flamebaiting Troll.
Uh oh, he's using asterisks... this can't last.
The well-known SJW AmiMoJo does a little dance on the slashdots.
Too bad it's not sexy, and doesn't come with a catchy tune either.
https://regmedia.co.uk/2015/07...
ah, feel better already. Gotta let that out or it builds and it builds and it builds and ... Trump.
Since when did Tux grow a set of tits?
Linus has been neutered by the SJW movement
Stress is unhealthy none the less. Deep breathing exercises works for me :)
[($)]
Linus Torvalds is a parent to 3 daughters. Nothing makes you grow up and be patient more than being a parent. lol
Europe and the planet stop fossile fuel and DON'T ENABLE THIS SHIT BY DEFAULT IN THE KERNEL. PÃRKELE!
Keep crying lol, nazi snowflakes. Your bitch traitor tears nourish baby Jesus. Trump will hang either way.
So some idiot does not even compile the code and does a pull request?
Person like that shouldn't just get yelled at, they should never be allowed to touch code again.
I think he took his month off to develop an AI that replaces his swear words with non-swear words surrounded in asterisks.
Compare 2010:
https://lkml.org/lkml/2010/5/20/218
This is just unbelievable SH*T: ...
First it says "only ask if EMBEDDED", and then it says "default to Y if
not embedded".
Why? Why the hell did somebody decide that everybody and their pet dog
should get that totally uninteresting driver, whether they want it or not?
I realize that every single developer thinks that their driver is the most
important thing in the universe, but come on! This kind of thing is
totally inappropriate, and to make matters worse, it looks like there are
a few commits that won't even compile because the whole file wasn't even
added until later.
And this piece of shit was made _mandatory_?
Get a grip, people. I'm not pulling idiotic crap like this. Some quality
control before you ask me to pull, for chissake!
2018:
We do *not* enable new random drivers by default. And we most *definitely* don't do it when they are odd-ball ones that most people have never heard of.
Yet the new "BigBen Interactive" driver that was added this merge window did exactly that.
Just don't do it.
Yes, yes, every developer always thinks that _their_ driver is so special and so magically important that it should be enabled by default. But no. When we have thousands of drivers, we don't randomly pick one new driver to be enabled by default just because some developer thinks it is special. It's not.... Please don't do things like this.
This is clearly developer behavior which Linus just HATES, but now he has to be polite in expressing his disdain for it.
I expect Linus to be committed to the looney bin in a matter of months.
If you want a healthy productive community, the correct way to handle repeated violations of policy is to document the policy and direct people to it when its violated.
If instead he said, you have violated our driver enablement policy, documented at link, then everyone one involved in the offending change making it in would have a much more pleasant time correcting their behavior and also have the opportunity to learn about such rules in advance easier.
In the software industry, it is standard practice to take repeat issues like this and document then in your best practices document along with examples and justifications. Its better for everyone involved (less work and stress for people like Linus, less being singled out and less feeling like they are being targeted by the contributors).
Personally I find that the canonical policy documentation is in Linus's head to be a bigger issue than his attitude. There is more to being fostering a positive developer community than not speaking in a rude way: you actually need to be inclusive/transparent when it comes to forming the policies, and in this case having a written best practices document everyone can read and discuss when they have disagreements rather than suffer a personal attack for an authority figure would make this a much better experience for most people.
At least that's my personal take coming from from the big company cooperate software engineering environment. I've dealt with this kind of feedback before, and it always feels like "my arbitrary opinion that you don't have access to says you should stop being wrong". I like it much better when a perceived mistake is instead address with the question of how we can help future people from making the mistake (ex: new documentation) or how I can help myself from making similar mistakes (ex: direct me to existing documentation). Its the difference of attitude between you messed up, vs how can we learn from this to improve the system so less people fall into the same trap you did.
This seems like a case study that can determine whether it is more important to be right or be polite.
So, was he right? (check yes or no)
Did he discriminate against someone? (check yes or no)
Did he sexually harass someone? (check yes or no)
Was he polite? (check yes or no)
One of these questions does not seem nearly as important as the others. Can you guess which it is?
We have found his twin brother. (See, the twin is NOT always evil =)
He still can't just say:
"Drivers are not to be enabled by default. Disable and resubmit."
Nope, he's STILL gotta go on a passive aggressive sarcasm-fest. Fuck that guy.
What about that? Damn social justice warriors.
Exactly. He's not using "bad words", but he's still being a smarmy asshole. He needs a good shot of humility along with some empathy, I'd guess.
I don't respond to AC's.
If the right person complains that they felt excluded, it won't matter. Once you hold up inclusiveness as a virtue, all bets are off.
I'm confused. I thought not being able to tell people they are morons meant he had to bend over and accept any sort of crap code into the kernel. But reading through this, I'm almost getting the impression that it's possible to maintain quality without being a prick about it. What am I missing?
No over-the-top belittling or cursing. But it still unnecessarily long/repetitive, contains multiple bolds/underlines, belittles a user/team, and is impolite. So while it is an improvement, couldn't he have just said something like:
"The BigBen Interactive driver was merged with the driver enabled. We generally do not enable new drivers by default, especially those that are more obscure. Please refrain from enabling new drivers to help keep the kernel more robust and stable. Thanks!"
Step up and be a leader, or dont bother running a project. And for the rest ( women,TG, whatever ), step up and show some guts, and skills, and stop whining its 'unfair'.
That's not Linus; the real LT is in an alien pod.
That's Pod Linus
I told someone that I'm predicting Linus will release some custom AI he wrote during the break.
He got tired of version control and went off an wrote Git, so what's the chance he went off and wrote some filtering software that intelligently replaces phrases with grammatically correct (and PC/SJW compliant) phrases?
He hinted at this before his absence, so I'm gonna bet he installed a "circuit breaker" that prevents tirades from leaving his mailbox.
Taking it up your ass like a sissy, bitch :)
A cool thing about documenting standards is you can then translate that English-language documentation into a Git hook and it'll be checked *automatically* as soon as it's committed. The developer will be notified of the problem even before any other person sees it.
In engineering, if it's wrong, it's probably better not to build it.
Building something wrong, so it doesn't work and is perhaps dangerous, is not a success.
Dear Linus, invent cars or trucks for the drivers (in the kernel).
Come on. He wrote a filter to translate what he really wrote into "acceptable, rainbow, speech."
We all play with the speak like a pirate filter, right? Linus wrote a similar filter and fed all his most offending emails through it as a test.
Why else would he have taken a little leave from the project?
It's the only way... :)
Please stop eavesdropping on other peoples mailing lists you are not a member of and have nothing constructive to contribute.
Please stop invoking hyperbole and extreme cherry picking to manufacture a narrative suggesting Torvalds was somehow unhinged before and now he isn't.
Every day I pray AmiMoJo and all pour souls like him afflicted with SJW related mental disorders get the professional help they so desperately need.
Old Linus speak
"You're an idiot...."
Means fix it up and resubmit.
New Linus speak
"I think that there might be an opportunity for improvement..."
means your about to be fired (or barred).
Be very very wary of people that are very polite.
Just repeat after me. Serenity now.
They always give you free fluoride for a year after 're-education'. Oh I'm so sorry, did I offend anyone?!?!
...is sometimes more terrifying.
Free Software world hero Linus Torvalds was forced either to resign from the Linux kennel project, or to act like a feminized soyboy, by blackmail. He fell for a honeytrap and was threatened with a #MeToo purge if he didn't resign. It's a corporate power grab, using "Social Just-Us" as a tool.
Hi,
Thanks for your article,
Good work keep it up.
https://www.be-practical.com/What-is-MERN-Stack-Development.html
No, it is usually much harder to write a perfect automatic hook, and if you did so, you wouldn't need to then document it at all (except for courtesy).
Oh fuck off. We do *not* enable new random drivers by default. And we most *definitely* don't do it when they are odd-ball ones that most people have never heard of.
Yet the new "BigBen Interactive" driver that was added this merge window did exactly that.
Just don't fucking do it.
Yes, yes, you always thinks that your driver is so special and so magically important that it should be enabled by default. But no. When we have thousands of drivers, we don't randomly pick one new driver to be enabled by default just because some developer thinks they are special. You're not. Don't fucking do things like this.
"Phoronix also describes another "kernel oops" testing Torvalds' patience, in which Linus responded tactfully that "What makes me *very* unhappy about this is that if I'm right, I think it means that code was literally not tested at all by anybody who didn't have one of the entries in that list.""
The sad part is, if I told somebody at Acclaim Systems that, the new management would fire me on the spot because it's against the executive office's policy to make offshored contractors feel bad about low quality or untested work. However, when said bug deploys into production five minutes after being committed to TFS and the public-facing application suffers an outage, the internal operations staff is held responsible for not bringing this issue, and a million others like it, to the attention of management. During the AAR meeting, however, nobody is to point to this issue as the source of the outage or present any solutions to resolve or avoid it, as that would be assigning blame and making the managers look bad for green-lighting untested code again.
Look, in my professional opinion, as bad as Linus screaming at people could be sometimes, there was always a way to avoid it - test your code and improve the quality of your work. That Linux has withstood constant assault for ~20 years and continued to improve is, in my personal opinion, a testament to strong leadership on the part of Linus. Without strong leadership, "management" takes hold, disinterested neglect sets in, covering up increasingly frequent emergencies crowds out everything else, and it's extremely difficult to right the ship's course.
As somebody living that nightmare of a project drowning in endlessly compounding stupidity, know that this path Linus is on will continue until nobody is allowed to challenge anything for any reason and Linux is rendered as impotent as any other project that is managed to death.
Who cares? Linux is dead, anyway.
First the indignity of systemd.
Then Linus cucks on the code of conduct.
Then IBM borgs Red Hat.
Linux has become all the things people used to get involved with Linux to get away from.
The best *campers* are *happy campers*
Dude ^
This is something, that the great German philosopher Immanuel Kant pointed out. It's possible to be just as cutting without using swear words. Look only at Dr. Ford from Westworld.
...he was busy writing a filter app that he runs all his communications through before they get sent/posted. That way he can still curse like before but only his new persona comes through the other end of the filter. Pretty smart if you ask me.
After Linus' recent return to have someone do this kind of crap seems like Trolling. WTF?
The question is, how will he react when someone tries something like (and I know this is over the top): /* Begin-Safe-Space */ /* Checking for NULL Pointers is triggering for me, /* End-Safe-Space */
So I won't do it. */
*ptr = 0;
And still calls people fucking morons! Just with the officially p.c. word police approved words!
So the only change is that he's now talking like a dishonest sleazebag too. "Good" ole US-American tradition, I guess.
PROTIP: It is irrelevant what words you use, to say something, for *saying* it.
How The openness of your tone only tells one something about how honest and trustworthy you are. And about the oppressive fake p.c.ness of the world you usually live in.
That's the main problem we Germans have with you US-Americans. We wouldn't even trust you to be open and hence honest about how your day was. Everything is fake. Politics, Eiffel towers, tits, ground beef, emotions and human relationships.
But congratulations on ruining somebody from the most direct no-bullshitting-around peoples on the planet. (Finns, Scandinavians, etc.)